Comments (2)
Hey @lalitkapoor, I have fixed the rendering issue with portals. The link you provided was indeed relevant although there was various other moving parts that needed also to be addressed. Apologies for taking this long to answer 😅 .
Yet as I have researched this topic, mainly by examining the other PM-React editors out there, I have found that using portals might not actually be preferable due to some React's async vs ProseMirror's sync rendering issues.
https://bitbucket.org/atlassian/atlaskit-mk-2/commits/d520a6fb6dab1027d3873eec9317c4e8574d07fb
Idk. Will have to research that later on if problems arise. Now I'm just trying to complete the full
editor.
from prosemirror-react-typescript-example.
@lalitkapoor I think I have now fixed the portals to the best of my ability as possible. The portals are rendered only once per dispatchTransaction
which should avoid a performance bottleneck with too many nodeViews firing updates in one transaction. But from what I can tell from the flame graphs I think the biggest bottle neck is now React itself as it is not maybe that suitable for rendering multiple small components vs one big tree. I have been thinking about implementing the example editor in Svelte to see how much better it is but time will tell.
from prosemirror-react-typescript-example.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prosemirror-react-typescript-example.