Code Monkey home page Code Monkey logo

Comments (12)

psklenar avatar psklenar commented on July 28, 2024

I am going to try create merge request about this ...

from tmt.

psss avatar psss commented on July 28, 2024

Thanks for the idea. Looking forward to the pull request.

from tmt.

thrix avatar thrix commented on July 28, 2024

@psklenar if you need any help/pointers to the implementation, we have each Tuesday hacking sessions, invited you!

from tmt.

psklenar avatar psklenar commented on July 28, 2024

@thrix suggest to add:
tmt plans update
to update https://src.osci.redhat.com/rpms/cpio/blob/rhel-8.2.0/f/ci.fmf

which updates some elements in NAME.fmf

from tmt.

psklenar avatar psklenar commented on July 28, 2024

or https://src.osci.redhat.com/rpms/lftp/blob/private-fmf-plan/f/ci.fmf

from tmt.

psss avatar psss commented on July 28, 2024

When thinking about this a little bit more I realized we could also support multiple values for each discover step option. This would only require to always provide the same set of options:

tmt plan create plans/basic \
    --name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
    --name fedora --how fmf --url https://fedora/ --ref master --filter tier:0 \
    --name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1

An empty string could be used for undefined options if needed like this:

tmt plan create plans/basic \
    --name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
    --name fedora --how fmf --url https://fedora/ --ref '' --filter ''
    --name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1

I guess this would also be a little bit easier from the implementation point of view. What do you think?

from tmt.

mruprich avatar mruprich commented on July 28, 2024

This sounds good, I will start working on a PR for you on this.

from tmt.

thrix avatar thrix commented on July 28, 2024

@psss would it make simpler to have a tmt plan update command which could update the plan with multiple discover phases, but it would be a separate command?

So your

tmt plan create plans/basic \
    --name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
    --name fedora --how fmf --url https://fedora/ --ref '' --filter ''
    --name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1

Would translate to

tmt plan create plans/basic --name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
tmt plan update plans/basic discover --name fedora --how fmf --url https://fedora/ --ref '' --filter ''
tmt plan update plans/basic discover --name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1

or something like that?

from tmt.

psss avatar psss commented on July 28, 2024

My impression is that adjusting existing plans in an automated way will not be such a common use case. I would expect that further changes of the existing fmf data will be done in most cases manually. Plus, from the implementation point of view, it's not that easy to update fmf node. It's quite easy when plan is stored in a separate file but thanks to elasticity you can also have multiple plans in a single file, and inheritance does not make this task easy either. Not that it would be impossible but for now I think we're good with extending the tmt plan create options.

from tmt.

psss avatar psss commented on July 28, 2024

@mruprich, any progress here? Is there anything blocking you? Can I help somehow?

from tmt.

mruprich avatar mruprich commented on July 28, 2024

No, sorry, I just got stuck on other issues. Hopefully I will have the solution ready tmrw.

from tmt.

psss avatar psss commented on July 28, 2024

Fixed by #219. See the documentation for usage examples.

from tmt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.