Comments (12)
I am going to try create merge request about this ...
from tmt.
Thanks for the idea. Looking forward to the pull request.
from tmt.
@psklenar if you need any help/pointers to the implementation, we have each Tuesday hacking sessions, invited you!
from tmt.
@thrix suggest to add:
tmt plans update
to update https://src.osci.redhat.com/rpms/cpio/blob/rhel-8.2.0/f/ci.fmf
which updates some elements in NAME.fmf
from tmt.
or https://src.osci.redhat.com/rpms/lftp/blob/private-fmf-plan/f/ci.fmf
from tmt.
When thinking about this a little bit more I realized we could also support multiple values for each discover
step option. This would only require to always provide the same set of options:
tmt plan create plans/basic \
--name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
--name fedora --how fmf --url https://fedora/ --ref master --filter tier:0 \
--name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1
An empty string could be used for undefined options if needed like this:
tmt plan create plans/basic \
--name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
--name fedora --how fmf --url https://fedora/ --ref '' --filter ''
--name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1
I guess this would also be a little bit easier from the implementation point of view. What do you think?
from tmt.
This sounds good, I will start working on a PR for you on this.
from tmt.
@psss would it make simpler to have a tmt plan update
command which could update the plan with multiple discover phases, but it would be a separate command?
So your
tmt plan create plans/basic \
--name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
--name fedora --how fmf --url https://fedora/ --ref '' --filter ''
--name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1
Would translate to
tmt plan create plans/basic --name upstream --how fmf --url https://github/ --ref devel --filter tier:0,1 \
tmt plan update plans/basic discover --name fedora --how fmf --url https://fedora/ --ref '' --filter ''
tmt plan update plans/basic discover --name rhel --how fmf --url https://rhel/ --ref rhel-8 --filter tier:1
or something like that?
from tmt.
My impression is that adjusting existing plans in an automated way will not be such a common use case. I would expect that further changes of the existing fmf data will be done in most cases manually. Plus, from the implementation point of view, it's not that easy to update fmf node. It's quite easy when plan is stored in a separate file but thanks to elasticity you can also have multiple plans in a single file, and inheritance does not make this task easy either. Not that it would be impossible but for now I think we're good with extending the tmt plan create
options.
from tmt.
@mruprich, any progress here? Is there anything blocking you? Can I help somehow?
from tmt.
No, sorry, I just got stuck on other issues. Hopefully I will have the solution ready tmrw.
from tmt.
Fixed by #219. See the documentation for usage examples.
from tmt.
Related Issues (20)
- Ansible package dependency for prepare, finish steps
- Ansible package dependency for prepare, finish steps
- Expose CLI invocation reset HOT 1
- Deprecation warning with docutils `frontend.OptionParser`
- `test.require` does not work with `context.distro` HOT 2
- Adjust on `provision.how` HOT 4
- Installing a local package does not work
- "Check first" and "Skip broken" flags are broken for installation of packages provided as files HOT 1
- Hard to debug `tmt plans ls` with remote plans HOT 1
- Ansible prepare step of imported plan does not work HOT 1
- 1.33 regression: `dist-git-source` behaves differently in different provisions
- 1.33 regression: Ssh fails with tmt-reproducer.sh HOT 2
- RFE: `tmt test id` option to check for duplicate IDs HOT 5
- Enable `vcpu`s number for `virtual` provisioning step HOT 1
- Load `resource_files` from external project
- Require an explicit user confirmation that 'provision -h local' can be executed'
- Suggesting additional sources for test requirements HOT 2
- All `tmt try` to accept generic steps options from `tmt run` HOT 6
- Prepare step should allow the run to continue on missing test requirements HOT 1
- Allow custom failure patterns in dmesg in test plan
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tmt.