Code Monkey home page Code Monkey logo

Comments (7)

technion avatar technion commented on August 15, 2024 2

It would appear that my concerns related only to creating a hash.
Given the position of encouraging people not to come up with their own salting scheme in the first place, I'm happy to stay firm on SALT_LEN as a hard coded input.

I'm pushing a fix now however that should allow it to verify existing hashes, which I've tested against your examples.

from ruby-argon2.

technion avatar technion commented on August 15, 2024 1

@micahhainline Given it's a bugfix, I will push a new release if no issues come up in another 24 hours.

from ruby-argon2.

technion avatar technion commented on August 15, 2024

Hi,

Thanks for this report. I'm going to take some time to look into an appropriate solution. Trying to mess with this has a knock-on effect of messing with the ENCODE_LEN constant, which exists in Ruby outside the C wrapper.

Being in this position would also involve messing with a recommended default, which I've been trying to discourage people from doing.

Regardless, let me look into a solution.

from ruby-argon2.

micahhainline avatar micahhainline commented on August 15, 2024

Any idea when we might see this in a release?

from ruby-argon2.

micahhainline avatar micahhainline commented on August 15, 2024

@technion wow! This is setting the bar for responsiveness! Thanks for turning it around so quickly!

from ruby-argon2.

technion avatar technion commented on August 15, 2024

@micahhainline No worries - it's a legit bug and can be fixed in a non-breaking way.

from ruby-argon2.

technion avatar technion commented on August 15, 2024

@micahhainline @asynchrony-ringo Version 1.1.1 has been tagged and pushed.

from ruby-argon2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.