JavaExtractor: Incorrect path length calculation about code2vec HOT 3 CLOSED

Hi James,
First, thanks! But it is actually counting edges and not nodes. I.e., the length of the path is defined there as the number of edges. Of course, the length could have been defined as the number of nodes (which is edges+1), but at the time I thought that counting edges makes more sense....
Additionally, the commonNode is decreased from the path length twice, so the result is the number of nodes in the path, excluding the common node, which equals to the number of edges.

I know it's a little confusing, I just ran it in debug mode and verified.
Your suggestion makes the length even smaller by 1.
I agree that maybe it could have made more sense to define the length as the number of nodes in the first place.

from code2vec.

Thanks for clearing that up. So the smallest path length is 2 as paths will always have at least three nodes: (source, parent+, target)?

from code2vec.

Yes, exactly.

from code2vec.