Code Monkey home page Code Monkey logo

Comments (11)

FireMasterK avatar FireMasterK commented on May 20, 2024 1

Edge displays the same behaviour, as in, the settings do get saved, however attempting to disable all sponsorblock options resets all options to their defaults.

I was able to replicate this issue, thanks for reporting!

I'll fix this later tomorrow

from piped.

FireMasterK avatar FireMasterK commented on May 20, 2024

There are two possibilities for this:

  • You have cookies/localstorage disabled
  • Something is preventing the settings from being saved in a particular browser

Can you take a screenshot of the localstorage tab in devtools? Please also specify the browser you are using.

from piped.

moriel5 avatar moriel5 commented on May 20, 2024

Will do so once I can turn on my desktop again (real life chores first).

And 3rd party cookies are blocked, but not local storage.

As for the browser, I have seen this behaviour on both Firefox (Nightly) and Edge (Dev), both on Solus (Linux).

from piped.

moriel5 avatar moriel5 commented on May 20, 2024

Sorry it took so long.
Oddly enough, on Edge, the values remained the same no matter what, while on Firefox they changed in accordance to what I had disabled (though still not saved).

Screenshot from 2021-04-18 02:43:55
Screenshot from 2021-04-18 02:44:43

from piped.

FireMasterK avatar FireMasterK commented on May 20, 2024

So, if I'm correct this is only reproducible when you disable everything. right?
(Enable Sponsorblock is still being saved correctly)

from piped.

moriel5 avatar moriel5 commented on May 20, 2024

It happens regardless of what I do, not just disabling everything.

from piped.

FireMasterK avatar FireMasterK commented on May 20, 2024

I'm sorry, but I'm still unable to reproduce this issue, could you try without any extensions?

from piped.

moriel5 avatar moriel5 commented on May 20, 2024

No problem, as soon as I'll be on my desktop.

from piped.

moriel5 avatar moriel5 commented on May 20, 2024

While testing performance in issue #132, I checked (extensions enabled) and it appears that it only happens when disabling all options.

The Chromebook is my sister's laptop, so I'll be running a proper check once I'm on my desktop (where Edge is also installed).

Update: Disabling all extensions does not change any anything, however interestingly, despite not showing anything changing within Local Storage, Edge displays the same behaviour, as in, the settings do get saved, however attempting to disable all sponsorblock options resets all options to their defaults.

from piped.

FireMasterK avatar FireMasterK commented on May 20, 2024

This issue should be fixed now, do let me know if it isn't!

from piped.

moriel5 avatar moriel5 commented on May 20, 2024

Thanks, I'll test it out when on my desktop.
Update: All's good now.

from piped.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.