Code Monkey home page Code Monkey logo

Comments (5)

Lampei avatar Lampei commented on July 30, 2024

Makes sense to me. I think I probably did it this way for my local environment which never used the original. Better to not break everyone's existing tests 😀

from cfselenium.

jamiejackson avatar jamiejackson commented on July 30, 2024

@Lampei, I'm confused about something:

This decides whether to use webSelenium or selenium, depending on arguments.

Whereas the v2 (WebDriver) tests seem to invoke selenium, not webSelenium.

Can you explain?

I was trying to write something up in the readme.md about how to use one or the other, but I got stuck trying to understand the existing code.

from cfselenium.

Lampei avatar Lampei commented on July 30, 2024

@jamiejackson I think you are just seeing a poorly named class at the time. I'm not sure why I named it Web selenium as that appears to be the old code, right? Selenium is the new Web driver. I think I actually confused myself at times with the naming.

from cfselenium.

jamiejackson avatar jamiejackson commented on July 30, 2024

Oh, that is confusing, but I see now. selenium.cfc=WebDriver and webSelenium.cfc=RC.

My first reaction would be to rename webSelenium.cfc to selenium.cfc (for backwards compatibility for folks who were invoking it directly), and rename selenium.cfc to WebDriverSelenium.cfc, or similar.

Thoughts?

from cfselenium.

Lampei avatar Lampei commented on July 30, 2024

Yup. Default to backwards compatibility first again. Definitely try to disambiguate it (seeing as both you and I know what's going on and we're still getting confused by it)

from cfselenium.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.