Library is not working on RN 0.60 about react-native-android-fullscreen-webview-video HOT 14 OPEN

I have fixed this issue and created a PR #28 but now I am getting another issue :

Requiring module "index.android.js", which threw an exception: Invariant Violation: Tried to register two views with the same name RNCWebView

from react-native-android-fullscreen-webview-video.

@loukrath I'd recommend just using react-native-webview, as they've added support for precisely what this library was created for.

from react-native-android-fullscreen-webview-video.

Having the same issue.

from react-native-android-fullscreen-webview-video.

Same issue +1

from react-native-android-fullscreen-webview-video.

I finally found the cause of this last issue, I had to set same version of react-native-webview in my root project as in react-native-android-fullscreen-webview-video:

"react-native-webview": "^5.12.1",

from react-native-android-fullscreen-webview-video.

Please merge pull request from @mikaoelitiana

from react-native-android-fullscreen-webview-video.

It looks like react-native-webview supports fullscreen Android video now, so there might actually not be a need for this library anymore:
react-native-webview/react-native-webview#325

Would someone be able to confirm that is the case?

from react-native-android-fullscreen-webview-video.

@amhinson thanks for pointing that. I will try if this is working.

from react-native-android-fullscreen-webview-video.

@mikaoelitiana can you confirm that if react native's webview supports that?

from react-native-android-fullscreen-webview-video.

Yes as far as I know it works fine

from react-native-android-fullscreen-webview-video.

@mikaoelitiana thanks man, i will try.

from react-native-android-fullscreen-webview-video.

The quickest fix is to change in iosWebView.js

import { WebView } from 'react-native';

to

import { WebView } from 'react-native-webview';`

And yes react-native-webview has to be installed.

from react-native-android-fullscreen-webview-video.

I got some error after I run react-native run-android.

• Error message:

  • Task :react-native-android-fullscreen-webview-video:compileDebugJavaWithJavac FAILED
  • Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
  • com.facebook.react.views.webview.WebViewConfig
  • com.facebook.react.views.webview.events.TopLoadingErrorEvent
  • dispatchEvent(this, new TopMessageEvent(this.getId(), message))

• Version:

  • react-native: 0.61.2
  • react-native-android-fullscreen-webview-video: 1.0.3
  • react-native-webview: 5.8.1

from react-native-android-fullscreen-webview-video.

@loukrath I'd recommend just using react-native-webview, as they've added support for precisely what this library was created for.

@amhinson It works for me, thanks

from react-native-android-fullscreen-webview-video.