Comments (3)
Consider the following demo:
class Character: # To simulate Lazuli's character class
def __init__(self, name):
self._name = name
@property
def name(self):
return self._name
@name.setter
def name(self, new_name):
if new_name == self._name: # checks for setting same name as before here, but it
# should check for DB matches in the actual engine instead
raise ValueError("That name is already taken!") # Message to be passed along on failure
else:
self._name = new_name
print("Creating character 'soul'")
soul = Character("soul")
print(f" Name: {soul.name}")
print("Setting name to clash")
try: # Simulate dependents using the setter following command issue from Discord bot
soul.name = "soul"
except Exception as e:
print("Error encountered")
if type(e) is ValueError:
# `print` used here, to simulate Discord message sending (by the bot)
print(f" Carrying over error message: {e.args[0]}") # Message to be passed along on failure
print(f" Name: {soul.name}\n")
print("Setting name to 'Souls'") # Simulates regular use; ignore this chunk
soul.name = "Souls" # only added as a sanity check to make sure
print(f" Name: {soul.name}\n") # the logic in this script is correct
print("Complete!")
Console Output:
from lazuli.
Suggested solution:
Add similar functionality to the setters, and provide documentation on how to propagate the error forward to the user in Discord,
Issue posted to log the issue.
TODO for upcoming patches.
from lazuli.
Fixed as of commit b401b9e
from lazuli.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lazuli.