Comments (28)
@Tasilee is correct - we probably need to add the 3km buffer here in this one and add a note similar to #73.
from bdq.
I suggest the Description:
'Do the geographic coordinates fall on or within the boundaries of the territory given in dwc:countryCode or its Exclusive Economic Zone?'
in place of:
'Do the geographic coordinates fall on or within the boundaries of the country (from dwc:countryCode ) plus its Exclusive Economic Zone?'
from bdq.
No matter the rendering, it will have to be explained. The suggestion by @chicoreus seems complete and logically consistent to me.
from bdq.
@ArthurChapman I agree, except I would be more explicit and say "- ZX is not a valid ISO 3166-1-alpha-2 country code".
from bdq.
Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet:
Given that the country was not inferred from the coordinates to begin with.
from bdq.
Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
@pz: again think of a sequence of pre-amendment, amendment, and post-amendment. The expectation in the case you describe in the pre-amememennt phase is that this valiation would return a result status of INTERNAL_PREREQUISITES_NOT_MET (no value of country to compare with coordinates), and that in the post-amendment phase would return the result of COMPLIANT
from bdq.
Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet:
Get it. Will we then define different profiles for pre- and post-? and sth like a route-plan? I think that's what's maybe missing for me, a graphical schema relating the tests over time, with multiple arrows showing what's next if pass or fail.
from bdq.
@tucotuco Why aren't we citing (ISO 3166-1-alpha-2 country codes) in this test like we have #48 - rather than say a specified target source authority?
from bdq.
@ArthurChapman No good reason I can think of. ISO 3166-alpha-2 seems exactly right to me.
from bdq.
OK - I will fix to be consistent with #48
from bdq.
INTERNAL_PREREQUISITES_NOT_MET if dwc:decimalLatitude, dwc:decimalLongitude, and dwc:countryCode are EMPTY;
should be if any of are empty, e.g.
"INTERNAL_PREREQUISITES_NOT_MET if one or more of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY;"
from bdq.
"INTERNAL_PREREQUISITES_NOT_MET if one or more of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY or contain values that cannot be interpreted;"
from bdq.
I am working through the test data and wondering if we need something more explicit (and consistent across tests) with the "interpreted" bit in the Expected Response:
INTERNAL_PREREQUISITES_NOT_MET if one or more of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY or contain values that cannot be interpreted;
Should this be something more like
INTERNAL_PREREQUISITES_NOT_MET if one or more of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY or contain values that cannot be interpreted as a valid numeric value;
?
from bdq.
@Tasilee To me that wording suggests that dwc:countryCode should be a numerical value. How about,
"INTERNAL_PREREQUISITES_NOT_MET if one or more of the values of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY or invalid."
from bdq.
I like that wording. If we agree to this, it will propagate to many other Expected Responses 🙄
from bdq.
See my comment of 14 February 2023 under test #56
from bdq.
I like @tucotuco 's use of "invalid" and given related discussions (no anomalies) about redundancy of checks for invalidity or similar, I have edited the Expected Response. We will need to check all Expected Responses accordingly.
from bdq.
As in #56, I think this one where a third example would be valuable - i.e. where countryCode in invalid which creates a response of "Response.status=INTERNAL_PREREQUISTES_NOT_MET, Response.comment="Input field contain invalid values""
e.g.
[dwc:countryCode="ZX", dwc:decimalLatitude="-41.0525925872862", dwc:decimalLongitude="-71.5310546742521": Response.status=INTERNAL_PREREQUISTES_NOT_MET, Response.comment="Input field contain invalid values - ZX is not a valid country code"]
from bdq.
Agree @Tasilee
from bdq.
Edited accordingly, with typo fix.
from bdq.
Restructured Parameter(s) and Source authority entries
from bdq.
@Tasilee @chicoreus We don't mention bdq:sourceAuthority in the Expected Response although we do in the Description and Parameter(s) - do we need to fix Expected Response or delete reference to the bdq:sourceAuthority
Should Expected Response read
EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if one or more of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY or invalid; COMPLIANT if the geographic coordinates fall on or within the boundary defined by the union of the boundary of the country from dwc:countryCode plus it's Exclusive Economic Zone as defined by the bdq:sourceAuthority, if any, plus an exterior buffer given by bdq:spatialBufferInMeters; otherwise NOT_COMPLIANT
from bdq.
@ArthurChapman That sounds almost right, but as marineregions.org doesn't actually define the EEZ regions, but provides a shapefile describing them, we should probably use slightly different language:
EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if one or more of dwc:decimalLatitude, dwc:decimalLongitude, or dwc:countryCode are EMPTY or invalid; COMPLIANT if the geographic coordinates fall on or within the boundary defined by the union of the boundary of the country from dwc:countryCode plus it's Exclusive Economic Zone as found in the bdq:sourceAuthority, if any, plus an exterior buffer given by bdq:spatialBufferInMeters; otherwise NOT_COMPLIANT
from bdq.
Updated Expected Response as per last comment and updated Specification Last Updated
from bdq.
Post Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax:
bdq:sourceAuthority default = "ADM1 boundaries" {[https://gadm.org] spatial UNION with "Exclusive Economic Zones" [https://marineregions.org]}
from bdq.
Since the sourceAuthority is a single parameter, not two, we need a single text string value as the default.
Something along the line of:
bdq:sourceAuthority default = "ADM1 boundaries UNION EEZ" {[https://gadm.org] spatial UNION [https://marineregions.org]}
from bdq.
Sounds logical to me @chicoreus. How would you render it @tucotuco ? I think there is another one like this somewhere...and I'll chase that down next.
from bdq.
The Source Authority issue seems to have been addressed.
from bdq.
Related Issues (20)
- TG2-VALIDATION_REPRODUCTIVECONDITION_STANDARD HOT 5
- TG2-AMENDMENT_REPRODUCTIVECONDITION_STANDARDIZED HOT 2
- TG2-VALIDATION_SEX_STANDARD HOT 11
- TG2-AMENDMENT_SEX_STANDARDIZED HOT 15
- TG2-VALIDATION_TYPESTATUS_STANDARD HOT 15
- TG2-AMENDMENT_TYPESTATUS_STANDARDIZED HOT 19
- TG2-ISSUE_COORDINATES_CENTEROFCOUNTRY HOT 9
- TG2-VALIDATION_DEGREEOFESTABLISHMENT_NOTEMPTY HOT 8
- TG2-VALIDATION_PATHWAY_NOTEMPTY HOT 3
- TG2-VALIDATION_INDIVIDUALCOUNT_INTEGER HOT 9
- TG2-ISSUE_OUTLIER_DETECTED HOT 12
- TG2-ISSUE_COORDINATES_OUTSIDEEXPERTRANGE HOT 18
- TG2-ISSUE_COORDINATEPRECISION_UNLIKELY HOT 33
- Broken link to Open Context HOT 3
- Generate MultiRecord Measures for QualityAssurance that return COMPLETE/NOT_COMPLETE for compliant HOT 6
- Generate MultiRecord Measures for QualityControl that count validations which are COMPLIANT HOT 4
- Generate MultiRecord Measures for QualityAssurance that return COMPLETE/NOT_COMPLETE for compliant and prerequisites not met. HOT 3
- New Test Template HOT 4
- Test Change Template HOT 1
- TG2-TO DO List for standard submission
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bdq.