subSchemas about jsonschema HOT 9 CLOSED

+1 for this issue -- I expected the first scenario above to work also. @tdegrunt Do you agree here?

from jsonschema.

I can see the benefit, but I'm having trouble locating information on this. I've checked http://json-schema.org/latest/json-schema-core.html#anchor7 . This project aims to be a faithful follower of the json-schema.org. If you can find any pointers/info, please let me know. /cc @ACubed

from jsonschema.

@tdegrunt I am not familiar with JSON Schema but I was reading some examples and I am not sure whether I missunderstood how to use the "required" keyword.

Now I am confused because I think I can accomplish what I was looking for doing something like

"use strict";

var Validator = require('jsonschema').Validator;
var v = new Validator();

var subSchema = {
    "id": "/subSchema",
    "type": "object",
    "properties": {
        "prop1": { "type": "string" },
        "prop2": { "type": "string" }
    },
    "required": [ "prop1", "prop2" ]
};

var schema = {
    "id": "/schema",
    "type": "object",
    "properties": {
        "prop1": { "$ref": "/subSchema"},
        "prop2": { "type": "string" }
    },
    "required": [ "prop1", "prop2" ]
};

var anotherSchema = {
    "id": "/schema",
    "type": "object",
    "properties": {
        "prop1": { "$ref": "/subSchema"},
        "prop2": { "type": "string" }
    },
    "required": [ "prop2" ]
};

var p = {
    "prop1": {
        "prop1": "Hello",
        "prop2": "World"
    },
    "prop2": "Hello World"
};

var p1 = {
    "prop2": "Hello World"
};

v.addSchema(subSchema, '/subSchema');
console.log(v.validate(p, schema));
console.log(v.validate(p1, schema));
console.log(v.validate(p, anotherSchema));
console.log(v.validate(p1, anotherSchema));

@jaysw can you test if this approach fits your use case?

from jsonschema.

I don't think that required:true on a property is a defined feature of json schema... The required: [] array of required properties is and works fine with this library today although both seem to work under some circumstances.

from jsonschema.

@Prestaul I do agree. I don't know how I didn't notice the required: [] at first glance.

from jsonschema.

@PauloASilva, you were right that this library seems to support required:true in some circumstances and it is demonstrated in the example in the readme. @tdegrunt, would it be wise to not feature this feature in the readme?

from jsonschema.

required:true is how JSON Schema draft-3 was defined, so it's allowed in the library for historical reasons.

In the next draft, we'll likely be abandoning the keyword altogether and getting "requiredProperties" in addition to the list of optional "properties".

from jsonschema.

@PauloASilva Does #100 I merged from @Prestaul fix your issue? If so, feel free to close this. Thanks!

from jsonschema.

Documentation update is enough to clarify how to deal with required. I'm closing this issue.
Thanks,

from jsonschema.