[@flopflip/launchdarkly-adapter] Specify different key to trigger `reconfigure` about flopflip HOT 4 CLOSED

Thanks for opening the issue. Really appreciate the kind words!

I understand your use case and I also think that a the E-Mail being a key is a perfect use has. In that the an E-Mail address or any primary key e.g. from a database makes a perfect user key.

The part I don't yet fully manage to follow is:

LaunchDarkly adapter to reconfigure because technically the user's key (email) is not changing.

In that: why does the adapter need to reconfigure? I assume to changeUserContext from the client's side? So that any newly "acquired characteristics" are updated with LD?

Thinking about it a bit it feels a bit like we should reconfigure once the user data is not deep-equal to the previous?

Note: the LD adapter exposes the { changeUserContext } function which I don't recommend. I might also like the equality check a bit more right now rather than manual/imperative updating of the key.

from flopflip.

What do you think about: #270

from flopflip.

@tdeekens - Great idea re: using deep-equal. That will solve the use case here. Thanks for the quick response and for taking care of the PR!

from flopflip.

https://github.com/tdeekens/flopflip/releases/tag/%40flopflip%2Flaunchdarkly-adapter%402.2.1

from flopflip.