Comments (15)
tasn
commented on August 23, 2024
2
Thanks for reporting. I can't believe this is an issue with signed pages, it was annoying me too! :)
I'll try to figure it out, thanks for reporting!
from webext-signed-pages.
tasn
commented on August 23, 2024
1
Released a new version.
from webext-signed-pages.
rugk
commented on August 23, 2024
Well… just disable the add-on and it works again, immediately. 😆
from webext-signed-pages.
tasn
commented on August 23, 2024
💔
from webext-signed-pages.
rugk
commented on August 23, 2024
This is really critical, as I just noticed…
In Firefox 69.0.1 it often breaks long-running (or big file?) downloads and I get this error:
/tmp/.../....part cannot be saved, because the source file cannot be read.
Originally reported at https://bugzilla.redhat.com/show_bug.cgi?id=1758895
from webext-signed-pages.
tasn
commented on August 23, 2024
Oh, thanks for the update!
Having just reviewed the code following your report there's indeed a problem. It seems like we just try to process and validate any "main_frame", though downloads (and icons?) can also be ones.
While reviewing the code I also spotted a few other issues:
- ondata may be called more than once (e.g. partial data every time) - we need to address that.
- We need to make sure the response is a utf-8 one rather than binary before we decide to process it - need to verify how this should be done exactly. This should fix this issue.
Are you able to consistently reproduce the download issue? If so, are you able to test a potential workaround?
from webext-signed-pages.
tasn
commented on August 23, 2024
Also, are you able to provide a link that fails? Or show the extension's output log? (Tools -> Web developer -> browser console)
from webext-signed-pages.
rugk
commented on August 23, 2024
Also maybe fix that TODO lol:
webext-signed-pages/src/background.js
Line 116 in 696d6d0
When the signature is not found, you can also add an if to return early instead of still decoding the text…
from webext-signed-pages.
rugk
commented on August 23, 2024
Maybe something like #23??
from webext-signed-pages.
tasn
commented on August 23, 2024
From #23: Could you please try if this branch fixes it for you: https://github.com/tasn/webext-signed-pages/tree/early-abort
I added an early abort in case we shouldn't check a page.
from webext-signed-pages.
rugk
commented on August 23, 2024
Do you have a prebuild ZIP or so?
from webext-signed-pages.
tasn
commented on August 23, 2024
I can upload something, but it won't be signed so you won't be able to
install it. I can release a new version soon, as I already tested it myself
and at the very least there are no regressions.
…On Wed, 9 Oct 2019, 19:09 rugk, ***@***.***> wrote:
Do you have a prebuild ZIP or so?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#17?email_source=notifications&email_token=AAA2Q7SWV7SUJA6PL6TUGE3QNX62NA5CNFSM4FZPQXO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYNOUY#issuecomment-540071763>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA2Q7TYFF72NNVCEBJVJXLQNX62NANCNFSM4FZPQXOQ>
.
from webext-signed-pages.
rugk
commented on August 23, 2024
Yeah, I can use about:debugging. That's easy…
from webext-signed-pages.
tasn
commented on August 23, 2024
Try this: signed_pages-0.4.1.zip
from webext-signed-pages.
rugk
commented on August 23, 2024
Hmm… could not reproduce the issue anymore right now… 🤔
But I guess it is fine… 😉
from webext-signed-pages.
Related Issues (20)
- (Optionally) use toolbar icon instead of address bar icon in Firefox HOT 4
- Always reports "No signature expected" HOT 8
- Show popup on bad/missing signature HOT 2
- Add release support/downgrade protection HOT 5
- Verify that SRI is used for all elements ("require-sri") HOT 4
- Add support for Minimizer Version HOT 9
- Change canonisation method from minimsation to something less intrusive HOT 5
- Chrome store extension doesn't think client.etesync.com is good. HOT 9
- Thoughts on "HTML Signing Profile"? HOT 2
- Support for DNS TXT record with master signing key for domain HOT 3
- Switch to minisign signatures?
- Code Verify browser extension + manifest HOT 1
- Support SSH signing HOT 1
- Disable JS for pages with a bad/missing signature HOT 3
- Extension no longer works in Firefox 118
- webext-signed-pages does not work with utf8 pages
- Verify JavaScript only HOT 6
- Sign git commits & releases HOT 10
- Bubled PGP keys: How to prevent forgery? How do you verify PRs? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webext-signed-pages.