Remove log usage from connection.go about go-tarantool HOT 6 CLOSED

I certainly could not remove logging. I could change it to something else. I'm open for discussion.

BTW: you could replace output of standard library to any io.Writer : https://golang.org/pkg/log/#SetOutput . Why you didn't do it?

from go-tarantool.

We could add logger field to the connection, and create default implementation writing to STDERR.
Anyone can change implementation as needed.

from go-tarantool.

@mialinx good idea, I have my own customer logger, so I can just define it as a parameter.

from go-tarantool.

Do I understand correctly, that all we need is:

type Logger interface {
     Printf(format string, v ...interface{})
}
type defaultLogger struct{}
func (d defaultLogger) Printf(format string, v ...interface{}) {
     log.Printf(format, v...)
}
type Opts struct {
// ....
     Logger Logger
}
func Connect() () {
// ....
    if conn.opts.Logger == nil {
        conn.opts.Logger = defaultLogger{}
    }
}

from go-tarantool.

Or we need to extend logger usage (for example, use something similar to pkg/syslog) ?

from go-tarantool.

@funny-falcon I think your variant is fine. If conn.opts.Logger == nil, you can use logger from standard logging library.

from go-tarantool.