Code Monkey home page Code Monkey logo

Comments (4)

mpiasta-ca avatar mpiasta-ca commented on May 24, 2024

Additional information - up to the width of 2000px, there are only 6 available selections for 740x656 that wouldn't cause a distortion in the resized PHP image:

925x820
1110x984
1295x1148
1480x1312
1665x1476
1850x1640

And if I changed that to 740x640, the amount of non-decimal choices would increase significantly:

777x672
814x704
851x736
888x768
925x800
962x832
999x864
1036x896
1073x928
1110x960
1147x992
1184x1024
1221x1056
1258x1088
1295x1120
1332x1152
1369x1184
1406x1216
1443x1248
1480x1280
1517x1312
1554x1344
1591x1376
1628x1408
1665x1440
1702x1472
1739x1504
1776x1536
1813x1568
1850x1600
1887x1632
1924x1664
1961x1696
1998x1728

from jcrop.

tapmodo avatar tapmodo commented on May 24, 2024

There are definitely precision issues when working with aspect ratios, resizing, etc. Just today I committed an update that removes all of the internal rounding that Jcrop was doing. The claim of the author is that this improves precision, which makes sense to me. If possible, can you retest with current master branch and advise if that improves on your issue? Other than that, there's not a lot of magic I can do to improve precision that isn't specific to a desired behavior that may vary from case to case.

from jcrop.

mpiasta-ca avatar mpiasta-ca commented on May 24, 2024

Tried the new version. I don't know what you changed, but IT WORKS! Can't believe it. Images are resized and the end result is high-quality. And the only thing I changed is I upgrade jcrop to latest version - didn't change any of the PHP. Thank you so much!

from jcrop.

tapmodo avatar tapmodo commented on May 24, 2024

Excellent! And thank you for letting me know. Some precision problems are inherent with all the scaling/division/etc... but in the code originally, much effort was made to be working with round numbers...I guess my thinking was that it would cause some obscure browser to choke on the CSS if it wasn't whole numbers. Anyway, this magnified the problem.

Someone recently submitted a patch that removed all the instances of rounding and claimed that it improved the precision. I had actually thought about this before (despite, if you can't tell, being lame at math) so I figured it was a logical change. Really great to hear that it helped a real life problem!

from jcrop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.