Configurable exit code about dnspyre HOT 6 CLOSED

Hello @PenelopeFudd 🙂
thanks for suggesting this enhancement, I think this enhancement makes sense and I like your suggestion to introduce a new flag --fail that will configure conditions upon which the dnspyre will exit with non-zero status

I can image supporting these conditions:

• ioerror = dnspyre exits with a non-zero status code if there is at least 1 IO error (dnspyre failed to send DNS request or receive DNS response)
• negative = dnspyre exits with a non-zero status code if there is at least 1 negative DNS answer (NXDOMAIN or NODATA response)
• error = dnspyre exits with a non-zero status code if there is at least 1 error DNS response (SERVFAIL, FORMERR, REFUSED, etc.)
• idmismatch = dnspyre exits with a non-zero status code if there is at least 1 ID mismatch between DNS request and response

and I will allow users to specify any combination of these conditions (like dnspyre --fail=ioerror,error google.com)

do you think this makes sense @PenelopeFudd?

This looks like the best DNS benchmarking program out there!

Thanks, glad to hear that 🙂

from dnspyre.

Yes, that's exactly it, thank you!

from dnspyre.

Hello @PenelopeFudd, I have released a new version v3.1.0 of dnspyre, that now supports --fail flag, you can check the documentation https://tantalor93.github.io/dnspyre/failoncondition.html for usage, hope it fits your use case! Thank you!

from dnspyre.

Er, one more request: --fail any, if any kind of error is found? Otherwise it's rather long to specify --fail ioerror --fail error --fail negative --fail idmismatch.

from dnspyre.

hmm, I understand, that it can be a little bit tedious to list all the conditions.

I am struggling with the semantics of such option any, it can be interpreted in many ways. Should it fail if there is any IOerror and DNS error, or should it also fail when there is a negative answer ? Negative answers usually are not a problem of the server but of the client asking for something that does not exist. Should truncated answers be considered also under the any option?

from dnspyre.

It's true that it could be interpreted in many ways, although I was thinking of the basic "any of the errors that could be specified with --fail", as a way to see if everything is perfect or not. If I start looking into negative or truncated answers, then it'd be time to explicitly list what counts as an error.

from dnspyre.