Comments (4)
@viktorbijlenga Yes, I've got notification about your PR, that's why I actually had a look into the code and chimed in. Your PR replaces the init
hook (which is correct) but does not mention non-frontend cases - admin and login, and doesn't explain why the change is being made.
Having seen your PR is why I said if I'm submitting a PR covering all scenarios, it might conflict with yours. Actually, you can amend your commit with admin_enqueue_scripts
and login_enqueue_scripts
plus some inline docs explaining the cases and close this issue.
from wp-functions.
I read your comment a bit to fast, so saw your mention a bit to late.
Feel free to improve or refactor my code with a new pull request if you find the time. Your additions sounds like great improvements to me.
from wp-functions.
No worries, I'll do it in the next few days.
from wp-functions.
What a coincidence. I submitted a Pull Request for this today. #30
from wp-functions.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-functions.