Code Monkey home page Code Monkey logo

Comments (5)

vsimko avatar vsimko commented on June 6, 2024

Could you provide a reproducible example ?
What are the objects M, L and U ?
(I assume M <- cor(mtcars))

from corrplot.

behinger avatar behinger commented on June 6, 2024

Here is the example (using corrplot_0.73)

M <- cor(mtcars)
L <- M-0.01
U <- M+0.01
corrplot::corrplot.mixed(M,lower='number',upper='circle',low=L,upp=U,plotCI='rect')

This results in:

Error in corrplot(corr, add = TRUE, type = "lower", method = lower, diag = (diag == : method shoud be circle or square if draw confidence interval!

from corrplot.

vsimko avatar vsimko commented on June 6, 2024

I fixed the error for now, but further API redesign is needed, I think.
Here is the output generated from your example code:
image

Please confirm whether this is the expected output.
If yes, please create a new issue and suggest the API change.

from corrplot.

behinger avatar behinger commented on June 6, 2024

This indeed works for me!

It only works for numbers though. Other cases:

corrplot::corrplot.mixed(M,lower='circle',upper='square',low=L,upp=U,plotCI='rect')
(lower boxplot, upper boxplot - expected: lower circle, upper boxplot)

corrplot::corrplot.mixed(M,lower='ellipse',upper='square',low=L,upp=U,plotCI='rect')
(lower empty, upper boxplot - expected: lower ellipse, upper boxplot)

corrplot::corrplot.mixed(M,lower='pie',upper='square',low=L,upp=U,plotCI='rect')
results in:

Error in corrplot(corr, add = TRUE, type = "lower", method = lower, diag = (diag == :
method shoud be circle or square if draw confidence interval!

I am not sure what kind of API redesign you are thinking of because I did not look into the underlying code. It is probably more helpful if you post the api change, because you know what needs to change in the api.

from corrplot.

vsimko avatar vsimko commented on June 6, 2024

I'm closing this for now, because it seems that I covered the use-case with my latest fix.

from corrplot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.