found-modern-universal branch does not work if built with fresh package-lock.json file about relay-todomvc HOT 10 CLOSED

Hey – I didn't have a chance to look at this yet. Did you resolve the problem?

from relay-todomvc.

Kind of.

My "solution" was to just admit defeat and use the package-lock.json file you committed, and just to be vigilant about committing it in the future. I'd prefer if the builds were possible with a fresh install without a lock file.

I prefer not to commit package-lock.json but this isn't necessarily right, although I do believe it's suggested that you do commit it. I've just had problems in the past working across teams with people adding packages and not committing the lock file, and then things start going wrong.

If there is a solution to this problem, I'd appreciate it. If not, I can live with using the lock file.

TIA

from relay-todomvc.

I did find that this was the last commit to work without using the lock file: 6b062cd

from relay-todomvc.

Well, there's clearly some sort of bug here that I'll track down, and I'll leave this issue open until I do.

Note that you are supposed to commit the lockfile, though: https://docs.npmjs.com/files/package-lock.json.

from relay-todomvc.

thanks

from relay-todomvc.

Thank you very much @taion. I'm going to take a look at this in the morning. I very much appreciate your time.

edit: Confirmed. Fixed. TYVM.

from relay-todomvc.

After checking out your new changes above, which work great, I get the same errors if I upgrade to relay 1.6. I read the changes and looked at the commits, but I still can't figure out why.

https://github.com/facebook/relay/releases/tag/v1.6.0

...
-    "react-relay": "~1.5.0",
-    "relay-compiler": "~1.5.0",
-    "relay-runtime": "~1.5.0",
+    "react-relay": "~1.6.0",
+    "relay-compiler": "~1.6.0",
+    "relay-runtime": "~1.6.0",
...

Any idea?

BTW thank you for your time!

from relay-todomvc.

The Relay 1.6 issues are due to facebook/relay#2429 (comment). I'd recommend staying on 1.5 for the time being.

from relay-todomvc.

Specifically, they're due to the upstream Relay bug described in that linked issue. It's not a bug in this code.

from relay-todomvc.

thank you

from relay-todomvc.