Code Monkey home page Code Monkey logo

Comments (5)

9999years avatar 9999years commented on August 24, 2024 1

Agreed that support for float durations would be really nice (I want to be able to parse 0.5 seconds).

I do understand not wanting to open this can of worms -- floats are tricky and this could add a lot of complexity. At the same time, I think @schneiderfelipe is right that even the most naive implementation would be very useful.

If this feature isn't added, we should improve the error message to clarify that decimals aren't allowed.

from humantime.

tailhook avatar tailhook commented on August 24, 2024

In the general case, It's unclear what precision of that should be. Is it all the way to nanoseconds?

from humantime.

schneiderfelipe avatar schneiderfelipe commented on August 24, 2024

For my use case, that would be unnecessary (seconds are enough).
But it makes sense for 1.5 hour to be as precise as 1 hour 30 min as possible?

from humantime.

tailhook avatar tailhook commented on August 24, 2024

For my use case, that would be unnecessary (seconds are enough). But it makes sense for 1.5 hour to be as precise as 1 hour 30 min as possible?

Well, but this should be configurable then, and it's a big piece of code in this case.

We probably have to do Duration::from_secs_f64(3600.*float_hours) instead. But then I'm not sure if just decimals are enough or somebody also wants exponential notation.

So I'm not sure if I want to open this can of worms.

from humantime.

schneiderfelipe avatar schneiderfelipe commented on August 24, 2024

We probably have to do Duration::from_secs_f64(3600.*float_hours) instead. But then I'm not sure if just decimals are enough or somebody also wants exponential notation.

Exponential notation would be too much, I think. Just parsing a simple float (\d+\.\d+) and doing the multiplication you suggested would be more than enough for most use cases I think.

from humantime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.