tabone / blockchain Goto Github PK

With the current implementation of the blockchain module, it is not possible to add a Queued Data object that is initialized from another Blockchain object. Although it is possible to extract the Queued Data data and include it in both Blockchain objects, each Queued Data will be having its own ID which may cause some issues when implementing blockchain-node since when a Block is created the Queued Data object which the new Block was created for should be removed from the queue.

With the current implementation of the Block module, the hash of a Block object is being generated in the main NodeJS process, resulting in the app to be completely blocked, thus making the solution implemented in #1 useless. For this reason the Hash Generation implementation should be extracted from the Block module and placed in its own JS file so that it can be executed in its own NodeJS process using the execFile function provided by the child_process modules.

With the current implementation of the Block module, when creating a new Block object which has its hash already generated, its state is being left as INITIALIZED. This should be changed so that the state of such Blocks is set to READY.

With the current implementation of the Blockchain module, when validating the Blockchain we are only validating the Block's hash. Logic should be included to also validate the Blockchain like for example:

• Block's previous hash
• Block's index

With the current implementation, when creating a Block for a Queue Data, the Block only stores the Queue Data data. With this approach there is the chance that multiple Blocks will be created for the same Queue Data. For this reason the Block module should be enhanced so that apart from the data it also stores the Queue Data ID.

With the current public api of the module, Blocks can only be added to the chain by being generated by the blockchain object. There is currently no way to push already generated Blocks. This functionality will be needed when implementing blockchain-node since Blocks may be generated from another blockchain object.

With the current implementation of the module, there is no way to abort the generation of a Block. Such functionality will be needed when implementing blockchain-node module since when a new Block will be received the blockchain-node should abort the current Block generation and start on a new one.