Code Monkey home page Code Monkey logo

Comments (4)

lllama avatar lllama commented on September 23, 2024 1

That seems fine. Explicit being better than implicit and all that. My only thought is whether AWS is moving to the lowercase example for future APIs. In which case a TagsV2Field might make more sense. But that would just be a guess as to what AWS are planning.

Happy with the proposed solution.

from altimeter.

lllama avatar lllama commented on September 23, 2024 1

A further thought after sleeping in it: at the moment, if the lowercase tags key is present, then the existing TagsField will silently fail to include the tags. It feels like this could be tricky to debug. Maybe check for the lowercase and print a warning?

from altimeter.

jbmchuck avatar jbmchuck commented on September 23, 2024 1

Sounds good. Due to other obligations and vacation it's fairly unlikely I'll be able to work on this until August 9th at the earliest but feel free to submit a PR if you end up implementing it.

from altimeter.

jbmchuck avatar jbmchuck commented on September 23, 2024

Thanks for the report! I'm hesitant to modify the existing TagField class but I'd definitely be open to adding a similar Field class which also produces a LinkCollection of TagLinks, in this case something like LowerCaseTagDictField which would expect a key tags containing a dict (rather than list of dict with Key, Value keys). Do you see any issues with that?

from altimeter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.