Comments (4)
That seems fine. Explicit being better than implicit and all that. My only thought is whether AWS is moving to the lowercase example for future APIs. In which case a TagsV2Field
might make more sense. But that would just be a guess as to what AWS are planning.
Happy with the proposed solution.
from altimeter.
A further thought after sleeping in it: at the moment, if the lowercase tags
key is present, then the existing TagsField
will silently fail to include the tags. It feels like this could be tricky to debug. Maybe check for the lowercase and print a warning?
from altimeter.
Sounds good. Due to other obligations and vacation it's fairly unlikely I'll be able to work on this until August 9th at the earliest but feel free to submit a PR if you end up implementing it.
from altimeter.
Thanks for the report! I'm hesitant to modify the existing TagField class but I'd definitely be open to adding a similar Field
class which also produces a LinkCollection
of TagLink
s, in this case something like LowerCaseTagDictField
which would expect a key tags
containing a dict (rather than list of dict with Key, Value keys). Do you see any issues with that?
from altimeter.
Related Issues (20)
- GuardDuty GetMasterAccount not always returns InvitedAt HOT 1
- Cloudtrail is not being scanned in ap-northeast-3
- generate_arn for IAM adds region HOT 3
- Allow continuing on scanning errors/support low privilege scanning HOT 12
- Example query showing incorrect results HOT 3
- Upgrade RDFLib to 6.0.0
- Question: ResourceLinkFields to two possible targets
- TagsField only supports tag lists HOT 1
- Make installable using pipx
- -bash: altimeter: command not found
- Cut a new release including the merged PRs #168 and #163 HOT 3
- NoRegionError: You must specify a region. causing Altimeter to crash on use. HOT 1
- All permissions needed HOT 4
- To work in Python 10 and greater
- what do NoRegionsFoundForResource exceptions mean?
- Use Pydantic where appropriate for data-container classes HOT 1
- Add 'name' triple on EC2 Instances HOT 2
- Publish an OWL ontology
- Make runnable in ECS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from altimeter.