Code Monkey home page Code Monkey logo

Comments (12)

tablacus avatar tablacus commented on June 6, 2024 1

The icon selection screen looks like this.
image

Click on 24px General
image

Click on 24px Browser
image

The download & install screen is going to take a little longer.

Regards,

from tablacusexplorericonpacks.

tablacus avatar tablacus commented on June 6, 2024 1

My preview image is like placing some typical icons in a rectangle.
It looks like the following.

image

Regards,

from tablacusexplorericonpacks.

tablacus avatar tablacus commented on June 6, 2024 1

I have a few requests.
I want preview.png to be lowercase.
Add the id to config.json.
The id is the same as the folder name.
Tablacus_Dark etc.

https://github.com/tablacus/TablacusExplorerIconPacks

Regards,

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024

My preview image is like placing some typical icons in a rectangle.

Ah yes much simpler and easier to achieve. I reformulated my preview images to follow your guidelines came up with a 256 x 160px size preview. What do you think, is that a good size?

Those icon selection screenshots looks cool too. I see now that most icons got an unintended white backdrop, that was not intentional, needs cleanup.

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024

I've created a new pull request with updated icons, tweaked a few of the existing ones for better appearance, and removed the white background for full transparency. Also added a new matching dark icon pack for night modes.

Let me know what you think, feel free to tell if you think any icons need adjustments or are not clear.
Also let me know if it is worth it making a rainbow-selection of matching colored icon packs based on the current as illustrated above.

from tablacusexplorericonpacks.

tablacus avatar tablacus commented on June 6, 2024

I think the preview size you suggested is good, but please consider it again when you have an installation page.

As I found out as I was building it, the following part of config.json is not currently in use and can be omitted.

    "icons": {
      "general": {
        "size": 64,
        "max": 43
      },
      "browser": {
        "size": 64,
        "max": 12
      },
      "shell32": {
        "size": 64,
        "max": 0
      }

Regards,

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024

I think the preview size you suggested is good, but please consider it again when you have an installation page.

I can easily adjust once you get the gallery up and running, and adapt to whatever size is required.

As I found out as I was building it, the following part of config.json is not currently in use and can be omitted.

    "icons": {
      "general": {
        "size": 64,
        "max": 43
      },
      "browser": {
        "size": 64,
        "max": 12
      },
      "shell32": {
        "size": 64,
        "max": 0
      }

Regards,

Will remove on next update, thanks

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024

Hey the new UI looks great, didn't expect to see it working in such short notice, great work.
I've updated the icon packs as requested, preview.png is now lower case, added id to config.json

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024

@tablacus I've made a few additions and changes to the icon pack.

  1. Can we use alphanumeric names for png icons in other folders? I've created a few misc category for a few upcoming changes, it'd be more convenient to have readable names, is this possible?
  2. Tree icon now uses shell32/41.png (before it was general/43.png), can you update in the UI for toolbar toggle tree button? That matches better with the original Microsoft designs.
  3. New Tab button which was before general/12.png has been moved to shell32/295.png or misc/new_tab.png to better match Microsoft. Will this cause trouble, can you update?
  4. I've added shell32/71.png for Options/Settings icon, so you can use it for the addon Options button and elsewhere.
  5. I've added shell32/289.png for tags (I think I've seen it used somewhere in the UI) and shell32/304.png for future use.

from tablacusexplorericonpacks.

tablacus avatar tablacus commented on June 6, 2024
  1. please try to install Tablacus Explorer 20.9.23.

Regards,

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024

Tree icon seems to be working well, not sure if you are using the one from misc already.

The dark preview is still using the old image, but github was stubbornly still showing the older one despite me uploading several times. I've made a pull request with an updated image, not sure it made it through this release yet.

The New Tab icon for the Simple Toolbar addon needs updating to show shell32/295.png or misc/new_tab.png, it is currently showing an icon for "Browse"

There is now an icon at shell32/289.png for the Label Button addon if you wish.
TE

Other than tah seems to be working well. Thanks for the hardwork

from tablacusexplorericonpacks.

duarteframos avatar duarteframos commented on June 6, 2024
  1. please try to install Tablacus Explorer 20.9.23.

Didn't get what you meant yesterday, but yes custom icons with alphanumeric names seem to be working correctly.
Custom Alphanumeric Icons
Successfully tested today by adding a button with a custom icon to the toolbar.

Now the only needed adjustments now are changing:

  1. Default icons for New Tab icon for the Simple Toolbar to show shell32/295.png or misc/new_tab.png
  2. Tree icon to shell32/41.png
  3. Optionally use shell32/289.png for the Label Button addon.

Thanks

from tablacusexplorericonpacks.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.