Comments (30)
IlyaSemenov
commented on September 3, 2024
1
My bad, I forgot to mention. This is 4.2.3, installed a couple days ago (as a got dependency).
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
1
❯ npm ls cacheable-lookup
[email protected] /Users/semenov/work/test
└─┬ [email protected]
└── [email protected]
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
1
npm install [email protected] [email protected]
This leads to:
test ❯ node
Welcome to Node.js v12.8.0.
Type ".help" for more information.
> const got = require('got');
undefined
>
> const CacheableLookup = require('cacheable-lookup');
undefined
>
> const dnsCache = new CacheableLookup();
undefined
>
> got.get('http://django.test:8000/admin/', {dnsCache}).then(res => console.log(res.body));
Promise { <pending> }
> (node:43447) UnhandledPromiseRejectionWarning: TypeError: Parameter `dnsCache` must be a CacheableLookup instance or a boolean, got Object
...
> dnsCache
CacheableLookup {
maxTtl: Infinity,
errorTtl: 0.15,
...
I figured it's because got lists "cacheable-lookup": "^4.3.0" as the dependency. Anyhow after I fixed the dependency/deleted extra modules from got/node_modules, that's what I get with wifi disabled:
❯ node
Welcome to Node.js v12.8.0.
Type ".help" for more information.
> const got = require('got');
undefined
> const CacheableLookup = require('cacheable-lookup');
undefined
> const dnsCache = new CacheableLookup();
undefined
> got.get('http://django.test:8000/admin/', {dnsCache}).then(res => console.log(res.body));
Promise { <pending> }
>
> (node:46652) UnhandledPromiseRejectionWarning: RequestError: cacheableLookup ENOTFOUND django.test
at ClientRequest.<anonymous> (/private/tmp/test/node_modules/got/dist/source/core/index.js:767:25)
at Object.onceWrapper (events.js:291:20)
at ClientRequest.emit (events.js:208:15)
at ClientRequest.EventEmitter.emit (domain.js:476:20)
at ClientRequest.origin.emit (/private/tmp/test/node_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
at Socket.socketErrorListener (_http_client.js:399:9)
at Socket.emit (events.js:203:13)
at Socket.EventEmitter.emit (domain.js:476:20)
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at CacheableLookup.lookupAsync (/private/tmp/test/node_modules/cacheable-lookup/source/index.js:183:18)
(node:46652) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:46652) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
and for comparison:
> got.get('http://django.test:8000/admin/').then(res => console.log(res.body.length));
Promise { <pending> }
> 1915
/private/tmp/test
├─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └── [email protected]
├── [email protected]
└─┬ [email protected]
├── @sindresorhus/[email protected]
├─┬ @szmarczak/[email protected]
│ └── [email protected]
├─┬ @types/[email protected]
│ ├── @types/[email protected]
│ ├─┬ @types/[email protected]
│ │ └── @types/[email protected] deduped
│ ├── @types/[email protected]
│ └── @types/[email protected] deduped
├─┬ @types/[email protected]
│ └── @types/[email protected] deduped
├── UNMET DEPENDENCY [email protected]
├─┬ [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ ├── [email protected] deduped
│ ├── [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ ├── [email protected] deduped
│ ├── [email protected]
│ └── [email protected] deduped
├─┬ [email protected]
│ └── [email protected] extraneous
├─┬ [email protected]
│ └─┬ [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected] deduped
│ └─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]
│ ├── [email protected]
│ └── [email protected]
├── [email protected]
├── [email protected]
└─┬ [email protected]
└── [email protected] deduped
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
1
I confirm that it works with [email protected].
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Are you using at least v4.2.0? Versions before that do not fall back to dns.lookup(...), so other DNS solutions than the hosts file don't work there.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
When developing, I recommend setting options.fallbackTtl to 3600 (1 hour).
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
When developing, I recommend setting options.fallbackTtl to 3600 (1 hour).
I tried it, and it (expectedly) didn't work:
> CacheableLookup=require('cacheable-lookup'); require('got').get('http://django.test:8000/admin/', { dnsCache: new CacheableLookup({ fallbackTtl: 3600 }) }).then(res => console.log(res.body))
Promise { <pending> }
>
> (node:26314) UnhandledPromiseRejectionWarning: RequestError: ENOTFOUND django.test
I'm not sure what TTL has to do with this. After all, the system might have never seen internet since boot, e.g. if I'm on a train in Cambodia. All other lookup methods correctly resolve django.test and cacheable-lookup fails to do so.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
What's the result of npm ls cacheable-lookup?
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Actually I can reproduce this, thanks for reporting!
from cacheable-lookup.
szmarczak
commented on September 3, 2024
This bug is really interesting. It should never happen.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Actually... um this is not a bug? I was following the Node.js docs:
dns.ADDRCONFIG: Returned address types are determined by the types of addresses supported by the current system. For example, IPv4 addresses are only returned if the current system has at least one IPv4 address configured. Loopback addresses are not considered.
I'll open a Node.js issue about that.
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
I was actually experiencing the same problem when my system had an IP address assigned by the router's DHCP server (192.168.0.x) but the router uplink was broken. So I don't think what you referred to was the only reason.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I don't know exactly how os.networkInterfaces() works under the hood. I just know that I can use it to mimic the ADDRCONFIG flag. But I think I know how to solve this problem. It may relate to DNS queries only, so local definitions won't be affected by this (I think).
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I can confirm that on Windows it works as expected (dns.lookup(...) throws).
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Relevant Node.js issue: nodejs/node#33279
from cacheable-lookup.
szmarczak
commented on September 3, 2024
@sindresorhus I think it would be a good choice to remove the HostsResolver and increase fallbackTtl to 60 (1 minute).
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I was actually experiencing the same problem when my system had an IP address assigned by the router's DHCP server (192.168.0.x) but the router uplink was broken.
That must've been a new interface. I guess the Node.js app had started before, right?
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
No, if that were the case and if it could have been fixed by simply restarting the node app I wouldn't be bothering opening this ticket.
This is what I've repeated just now:
- I ran
nodeandrequire('got').get('http://django.test:8000/admin/').then(res => console.log(res.body));, it worked fine - I unplugged ISP cable from the router (my laptop wifi<->router connection stayed intact,
ifconfigoutput didn't change). - I repeated step (1) running fresh
node, it crashed with:connect ECONNREFUSED 192.168.0.1:8000(????) - very odd, why would it be trying connecting the router at port 8000? - I plugged ISP cable back to the router
- I repeated step (1) running fresh
node, it still crashed - I repeated step (1) running fresh
node, it worked fine
ifconfig output never changed during the process, I tested with diff:
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> mtu 16384
options=1203<RXCSUM,TXCSUM,TXSTATUS,SW_TIMESTAMP>
inet 127.0.0.1 netmask 0xff000000
inet6 ::1 prefixlen 128
inet6 fe80::1%lo0 prefixlen 64 scopeid 0x1
nd6 options=201<PERFORMNUD,DAD>
gif0: flags=8010<POINTOPOINT,MULTICAST> mtu 1280
stf0: flags=0<> mtu 1280
en0: flags=8863<UP,BROADCAST,SMART,RUNNING,SIMPLEX,MULTICAST> mtu 1500
options=400<CHANNEL_IO>
ether a4:5e:60:d5:b5:b5
inet6 fe80::8b7:9dfc:931:ee60%en0 prefixlen 64 secured scopeid 0x4
inet 192.168.0.18 netmask 0xffffff00 broadcast 192.168.0.255
nd6 options=201<PERFORMNUD,DAD>
media: autoselect
status: active
p2p0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 2304
options=400<CHANNEL_IO>
ether 06:5e:60:d5:b5:b5
media: autoselect
status: inactive
awdl0: flags=8943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1484
options=400<CHANNEL_IO>
ether 8a:5d:12:f3:91:21
inet6 fe80::885d:12ff:fef3:9121%awdl0 prefixlen 64 scopeid 0x6
nd6 options=201<PERFORMNUD,DAD>
media: autoselect
status: active
llw0: flags=8863<UP,BROADCAST,SMART,RUNNING,SIMPLEX,MULTICAST> mtu 1500
options=400<CHANNEL_IO>
ether 8a:5d:12:f3:91:21
inet6 fe80::885d:12ff:fef3:9121%llw0 prefixlen 64 scopeid 0x7
nd6 options=201<PERFORMNUD,DAD>
media: autoselect
status: active
en1: flags=8963<UP,BROADCAST,SMART,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1500
options=460<TSO4,TSO6,CHANNEL_IO>
ether 82:13:03:d1:ff:80
media: autoselect <full-duplex>
status: inactive
en2: flags=8963<UP,BROADCAST,SMART,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1500
options=460<TSO4,TSO6,CHANNEL_IO>
ether 82:13:03:d1:ff:81
media: autoselect <full-duplex>
status: inactive
bridge0: flags=8863<UP,BROADCAST,SMART,RUNNING,SIMPLEX,MULTICAST> mtu 1500
options=63<RXCSUM,TXCSUM,TSO4,TSO6>
ether 82:13:03:d1:ff:80
Configuration:
id 0:0:0:0:0:0 priority 0 hellotime 0 fwddelay 0
maxage 0 holdcnt 0 proto stp maxaddr 100 timeout 1200
root id 0:0:0:0:0:0 priority 0 ifcost 0 port 0
ipfilter disabled flags 0x0
member: en1 flags=3<LEARNING,DISCOVER>
ifmaxaddr 0 port 8 priority 0 path cost 0
member: en2 flags=3<LEARNING,DISCOVER>
ifmaxaddr 0 port 9 priority 0 path cost 0
nd6 options=201<PERFORMNUD,DAD>
media: <unknown type>
status: inactive
utun0: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 1380
inet6 fe80::50b2:9471:dbc5:ac64%utun0 prefixlen 64 scopeid 0xb
nd6 options=201<PERFORMNUD,DAD>
utun1: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 2000
inet6 fe80::9acb:ae4c:2b68:e8ce%utun1 prefixlen 64 scopeid 0xc
nd6 options=201<PERFORMNUD,DAD>
ping django.test, curl http://django.test:8000/admin/ and axios all worked fine regardless of the connectivity. (as expected)
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I tried the same but with my Ethernet cable directly plugged into my computer. Will try with the router now.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I tried your steps but was playing with the hosts file instead, because my distro doesn't allow me to alter resolv.conf. I wasn't able to reproduce. I'll run ubuntu in docker and see how's things.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Ok, so I created an Ubuntu instance, set up dnsmasq, installed latest Node.js 12 and ran require('got').get('http://asdf.test').then(response => console.log(response.body.length)) and everything worked. My PC was disconnected from Internet. Note that *.test points to my nginx server.
root@972c5d938765:/bug# npm ls
[email protected] /bug
`-- [email protected]
+-- @sindresorhus/[email protected]
+-- @szmarczak/[email protected]
| `-- [email protected]
+-- @types/[email protected]
| +-- @types/[email protected]
| +-- @types/[email protected]
| | `-- @types/[email protected] deduped
| +-- @types/[email protected]
| `-- @types/[email protected] deduped
+-- @types/[email protected]
| `-- @types/[email protected] deduped
+-- [email protected]
+-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected] deduped
| +-- [email protected]
| `-- [email protected] deduped
+-- [email protected]
| `-- [email protected]
+-- [email protected]
| `-- [email protected]
| +-- [email protected]
| | `-- [email protected] deduped
| `-- [email protected]
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| `-- [email protected]
+-- [email protected]
+-- [email protected]
`-- [email protected]
`-- [email protected] deduped
from cacheable-lookup.
szmarczak
commented on September 3, 2024
connect ECONNREFUSED 192.168.0.1:8000
What's the stack trace?
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Released [email protected] which has disabled DNS cache by default.
from cacheable-lookup.
IlyaSemenov
commented on September 3, 2024
What's the stack trace?
with Internet connectivity:
test ❯ node
Welcome to Node.js v12.8.0.
Type ".help" for more information.
> require('got').get('http://asdf.test:12345').then(response => console.log(response.body.length))
Promise { <pending> }
> (node:28301) UnhandledPromiseRejectionWarning: RequestError: connect ECONNREFUSED 127.0.0.1:12345
at ClientRequest.<anonymous> (/Users/semenov/work/test/node_modules/got/dist/source/core/index.js:786:25)
at Object.onceWrapper (events.js:291:20)
at ClientRequest.emit (events.js:208:15)
at ClientRequest.EventEmitter.emit (domain.js:476:20)
at ClientRequest.origin.emit (/Users/semenov/work/test/node_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
at Socket.socketErrorListener (_http_client.js:399:9)
at Socket.emit (events.js:203:13)
at Socket.EventEmitter.emit (domain.js:476:20)
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1056:14)
(node:28301) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:28301) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
without internet (unplugged ISP cable from the router, ifconfig on the laptop didn't change):
test ❯ node
Welcome to Node.js v12.8.0.
Type ".help" for more information.
> require('got').get('http://asdf.test:12345').then(response => console.log(response.body.length))
Promise { <pending> }
> (node:28187) UnhandledPromiseRejectionWarning: RequestError: connect ECONNREFUSED 192.168.0.1:12345
at ClientRequest.<anonymous> (/Users/semenov/work/test/node_modules/got/dist/source/core/index.js:786:25)
at Object.onceWrapper (events.js:291:20)
at ClientRequest.emit (events.js:208:15)
at ClientRequest.EventEmitter.emit (domain.js:476:20)
at ClientRequest.origin.emit (/Users/semenov/work/test/node_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
at Socket.socketErrorListener (_http_client.js:399:9)
at Socket.emit (events.js:203:13)
at Socket.EventEmitter.emit (domain.js:476:20)
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1056:14)
(node:28187) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:28187) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
you can see how the IP changes.
This could be perhaps something Mac OS-related.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Can you try #31 (fixes branch) and see if it fixes the issue?
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I managed to make all the current tests pass there. But it's missing some new tests anyway. Can you try it?
from cacheable-lookup.
szmarczak
commented on September 3, 2024
I've released [email protected]. Please try the following:
npm install [email protected] [email protected]
const got = require('got');
const CacheableLookup = require('cacheable-lookup');
const dnsCache = new CacheableLookup();
got.get('http://django.test:8000/admin/', {dnsCache}).then(res => console.log(res.body));Please let me know if it's fixed or not.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
That's good news! I think the problem is that resolve4 and resolve6 finish before dns.lookup so it doesn't have the chance to get the entries from the OS.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Can you try again with [email protected]? Thanks.
from cacheable-lookup.
szmarczak
commented on September 3, 2024
Closing due to lack of response. I cannot reproduce it anymore with the newest version.
from cacheable-lookup.
Related Issues (20)
- Fallback fails when one family returns ENOENT HOT 1
- TS error when using QuickLRU from readme example HOT 5
- Querying for family=6 when family=4 is explicitly requested? HOT 3
- Question: How is DNS resolved? HOT 2
- DNS lookup are not cached HOT 3
- TS incompatibility between CacheableLookup.lookup and @types/node LookupFunction HOT 2
- round-robin dns support HOT 2
- Jest reporting CachableLookup is preventing shutdown HOT 3
- Ability to set minTtl? HOT 1
- Add stats to see how many calls were cached HOT 1
- Can you obtain the local hosts first and then use resolve4 or resolve6 HOT 5
- dns lookup is not cached the way I understand HOT 1
- Cacheable lookup responds with ESERVFAIL while native dns.resolve works HOT 10
- Enable tests again
- http2 & cacheable-lookup HOT 1
- Source isn't returned in Entry object HOT 1
- No way to dispose and timeout problems HOT 1
- Prefetch before expiration
- dnsCache.lookup types might be wrong? HOT 1
- Is there a version which supports CJS ? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cacheable-lookup.