Code Monkey home page Code Monkey logo

Comments (2)

jxnblk avatar jxnblk commented on August 27, 2024 1

@souporserious Awesome! This isn't too far off from what I was thinking. The current ColorMode component also uses Global (it'd be great if global CSS could generally be avoided though). With theme-ui and color modes, I think it'd make sense for each mode's custom properties were on something like a .theme-ui-color-<MODE> selector so that the render-blocking script used on page load would only need to apply a single classname to the <body> element

If you're down to start a PR, that'd be great!

from theme-ui.

souporserious avatar souporserious commented on August 27, 2024

I messed around with this a couple of weeks ago here. Landed on adding an includeCSSVariables prop to ThemeProvider that created the CSS properties through Emotion's Global component so it should be SSR friendly.

If you think that's similar to what you're thinking I'd be happy to start a PR and discuss things further :)

from theme-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.