How to deal with external link error types that may be temporary (e.g. timeout, 500) about brofix HOT 4 OPEN

However, it might make sense to have historic information and for example only mark it as broken if the third check fails.

We already have the link target cache. Additional information could be stored there.

Another option might be to categorize by error type and give the user the option to filter these out in the list.

I think the effort is not worth it for this, but if the change may give some other useful results, we might consider it.

from brofix.

Maybe Error 500 should not be available as exclusions records?

Or maybe add a "do not test until" date field and a Scheduler job that delete those records once the date is reached. The field would be filled at exception creation with a calculated date with a default of 7 days. Or something like that.

from brofix.

Maybe Error 500 should not be available as exclusions records?

good point.

Or maybe add a "do not test until" date field and a Scheduler job that delete those records once the date is reached.

Ok, you mean in the tx_brofix_exclude_link_target (for excluding the links from link checking).

I like that. That might be a good idea, not just for the 500 errors. Probably, the usual starttime, endtime could be added to the table, as is the convention in TYPO3.

I am not sure if we should implement all of this now, but these changes do not seem to be overly complex.

from brofix.

I currently prefer solution to prevent "exclude button" for some error types (e.g. 500). For error types which we know are errors.

The exclude button was originally meant to remove the "false positives" from the list.

We already have this configuration:

 excludeLinkTarget {
    storagePid = 0
    # allowed link types, e.g. external,db
    allowed = external
  }

We can add (as regular expression):

excludeLinkTarget.denied.errorTypes = httpStatusCode:5[0-9]{2}

from brofix.