Code Monkey home page Code Monkey logo

Comments (3)

syoyo avatar syoyo commented on August 26, 2024

You should describe details

from tinyexr.

fknfilewalker avatar fknfilewalker commented on August 26, 2024

Oh yes sorry

In the cmake the following line gets executed when the compiler used is clang.

set_source_files_properties(${TINYEXR_SOURCES} PROPERTIES COMPILE_FLAGS "-Weverything -Werror -Wno-padded -Wno-c++98-compat-pedantic -Wno-documentation -Wno-unused-member-function")

The problem here is that there are some warnings that get turned into errors now on the windows side making the code not compile with clang-cl.

So either we fix the code in tinyexr.cc so that these warnings/errors for windows get resolved or we deactivate these compiler flags for clang-cl on windows.

from tinyexr.

syoyo avatar syoyo commented on August 26, 2024

Ah, o=it is needed to wrap it with MSVC to detect clang-cl.

if (MSVC) 
  if (CMAKE_CXX_COMPILER_ID SQTEQUAL "Clang")
    // clang-cl
  else() 
    // cl.exe
  endif()
endif ()

You can contribute! PR is much appreciated.

from tinyexr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.