Comments (9)
Awesome! I'll make a pull request to fix this issue.
from hast-util-to-html.
@wooorm Hmm I think we can just close this issue now. I've checked the code again and I like the fix currently applied. We use Omit
only once in this package so I don't think it is worth to configure the rule in package.json.
from hast-util-to-html.
OK! Thanks for looking into it & working on it!
from hast-util-to-html.
In my opinion, the rule can be ignored. Omit
doesn't check the omitted props exist in StringifyEntitiesOptions
. So if we replace it with Except
from type-fest, it would be a little bit helpful for us to detect trivial typos when we rename the omitted props in StringifyEntitiesOptions
. And I don't think we would like to rename them that often. So i think we can just disable banning usage of Omit
rather than introducing more dev deps.
@ChristianMurphy How do you think?
from hast-util-to-html.
I'd agree, I think adding another devDependency
would like cause more frustration than the benefit Except
brings. We can probably safely disable this rule.
from hast-util-to-html.
@wooorm How can I reproduce the error message? Apparently we aren't using typescript-eslint rules for this repository.
from hast-util-to-html.
I think updating dtslint to 3 gave me that error.
Xo does have typescript-eslint internally I believe
from hast-util-to-html.
Ah, I turned them off while updating: 1b34d25
from hast-util-to-html.
I see. I'll discard the comment and try to fix it again.
from hast-util-to-html.
Related Issues (20)
- Better SVG minification HOT 1
- allowDangerousCharacters is still encoding '&' when its set to true HOT 3
- Head elements are not wrapped in a Head tag HOT 3
- Head elements are not wrapped in a Head tag HOT 7
- Support minifying comments further
- Prevent kebab case datatype? HOT 7
- Circular dependencies breaks rollup and vite builds HOT 4
- Text is encoded even when setting allowDangerousCharacters/allowDangerousHtml HOT 6
- failed to compile ts code using hast-util-to-html HOT 5
- Add support to format the HTML in a tidy fashion HOT 9
- `list-style-type` is stringified incorrectly HOT 1
- Force self-closing tags to be manually closed tags HOT 8
- Add missing "type": "module" to package.json for Vite resolution HOT 3
- missing whitespace in root node HOT 2
- re: missing whitespace in root node HOT 5
- Request more control over escaping HOT 6
- Reduce dependencies size HOT 3
- Possibility of configuring characters subset HOT 3
- Do not output unneeded entities in `<script>` or `<style>` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hast-util-to-html.