CI Failing about fintech-to-ynab HOT 8 CLOSED

ah, mybad, I had added mock module for the tests, in my requirements.txt but it wasnt in the testable branch`

from fintech-to-ynab.

No problem :) do you want to PR it in, or should i add it? If so, what am i adding?

from fintech-to-ynab.

just sent a PR that adds it, should solve the issue

from fintech-to-ynab.

@rienafairefr awesome thanks.

I fixed a couple of the tests (due to the new data dict) but a few in test_app are still failing.

from fintech-to-ynab.

I see the problem. Send you a pr in a sec

from fintech-to-ynab.

Last one:

======================================================================
FAIL: test_secret (tests.unit.test_app.TestRoutes)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/fintech-to-ynab/tests/unit/test_app.py", line 17, in test_secret
    self.assertEqual(response.status_code,403)
AssertionError: 400 != 403

from fintech-to-ynab.

I think it's the URL_SECRET environment variable that doesnt exist in CI ?

from fintech-to-ynab.

I can reproduce locally if I remove URL_SECRET=[...] from my .env

from fintech-to-ynab.