Comments (7)
I'd remove the type- part in all cases because in Symfony Forms, extensions can only be about "types", so it's redundant.
that's not true. The component has both a FormExtension and a FormTypeExtension (but the FormExtension is not that used, as we rely on the DependencyInjectionExtension in any project using FrameworkBundle, and we configure this extension instead).
from maker-bundle.
I guess it's OK to add this maker. About the naming, we need to carefully think about this (not only for this proposal, but for others).
At first we thought we could use this syntax: make : xxx
(e.g. make:twig-extension
) to avoid the boring triple namespace (make:twig:extension
). It's great because it's short. And for cases like Twig, it's the best option because we won't generate anything related to Twig except the extension, so there won't be more make:twig:xxx
.
However, for things like auth
, we are planning to do make:auth:xxx
so maybe we cannot escape from the triple namespace curse. In summary, we already have make:form
; if we add this command, what's the best name for it?
make:form:extension
make:form-extension
I'd remove the type-
part in all cases because in Symfony Forms, extensions can only be about "types", so it's redundant.
from maker-bundle.
Regarding the naming, I don't think the type extension should be named based on the type it extends. You can have many type extensions extending the same type.
Naming them based on the feature they add is much better.
from maker-bundle.
You can have many type extensions extending the same type. Naming them based on the feature they add is much better.
@stof Good point! I agree.
So, it should be named make:form-type-extension
? i.e to avoid the triple namespace?
from maker-bundle.
See #85
from maker-bundle.
any chance this can be revived?
If I provide an implementation based on the initial implementation from @yceruto can this be merged to master?
from maker-bundle.
I would be 👍 for having this maker :) The original PR was just SO early in Maker dev, that we changed a bunch of stuff and broke that PR :/.
from maker-bundle.
Related Issues (20)
- [make:entity] addGetter on boolean field that starts with "is" HOT 1
- [make:entity] `generate()` call to `is_string()` appears to always evaluate to `false`
- Missing ? in symfony console make:entity? HOT 9
- Critical error: ClassSourceManipulator HOT 4
- [make:entity] Exception in DoctrineHelper.php HOT 2
- Why is the registration confirmation link (verify-email-bundle) not working in Symfony 6 ? HOT 8
- [make:auth] V1.59 - Deprecated classes causes deprecated message on each page HOT 1
- [make:entity] no more autocompletion on repository methods HOT 1
- Use final classes
- Deprecation : symfony/maker-bundle v1.59.0 HOT 1
- PHPStan - User::getPassword()
- PHPStan - ResetPasswordRequest::getUser()
- [make:crud] Add support for dynamic CSRF id with Expression in `#[IsCsrfTokenValid]`
- [make:crud] Allow `EntityValueResolver` to return a list of entities
- [make:registration-form] Add `hash_property_path` option to `PasswordType` HOT 1
- [make:reset-password] Add `hash_property_path` option to `PasswordType` HOT 1
- [make:entity] Entity Names Should Be Allowed to Have Digits (i.e. v1) HOT 1
- [make:entity] default value
- [make:entity] Maker modifies vendor files if FQCN covers up local alias HOT 2
- Feature Request: Allow custom Generator class in MakerInterface
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maker-bundle.