Comments (5)
But would projects themselves need to create makers ? I'm not sure about it. third-party makers are more likely to be provided by third-party bundles than by projects themselves IMO.
from maker-bundle.
I thought about this... I wasn't sure. It shouldn't be that common... and there's a small cost: it's another command that the user needs to look through when trying to find the one they want.
from maker-bundle.
It shouldn't be that common
Yep, it isn't right now, because the bundle is really very new, but I think it will be. I have many skeletons specific to other libraries (not directly related to Symfony) that I would love to not have to create manually, so I'll need the maker.
I know, I can create my own make:maker
but I will have to update it constantly with the latest changes in the bundle, as well as the documentation (here) related to how create a new one.
it's another command that the user needs to look through when trying to find the one they want.
I think it is very subjective depending on whether the maker is really necessary or no.
from maker-bundle.
I'm not sure either. We could add it as a hidden command though.
from maker-bundle.
But would projects themselves need to create makers ?
@stof I think so, in case your applications need to generate custom boilerplate code, also there is not way to override a skeleton template ATM (and we probably will not have it), so how I can modify it?
Current steps to create your own maker:
- Find the documentation of the MakerBundle and read it.
- Create the class that implements
MakerInterface
. - Find the skeleton template to reuse or create a new one.
- Understand the architecture! (The most complicated step for everyone)
- Done! try and add a test case, as I need to make sure that future changes made to the bundle don't break my maker.
It is not too easy really IMHO.
The make:maker
command should be visible on bin/console list make
. It can provide the nicer maker class with important comments (jumping steps 1, 2 and 4), this one could ask me: do you want to reuse one or create a new skeleton template? It could create the base skeleton template for me (step 3) with important comments (mandatory <?= "<?php\n" ?>
), even it could ask (step 5): do you want to add a test case class for this new maker? oh, definitely yes :)
The big question is, if we already have the possibility of creating our own maker, why not make the path happy?
from maker-bundle.
Related Issues (20)
- Support target directories other than the first one matching a namespace HOT 1
- Add maker for decorate services
- [sym7] Make:user not compatible with phpstan HOT 4
- make:entity always call ORM\Id id HOT 2
- Why generated not nullable fields have nullable types (?T) instead of type (T) HOT 1
- [Make:Listener] Improve event name matching HOT 1
- make:auth remember_me strategy is always set to "Always activate remember me"
- Replace or remove "file_link" filter ?
- make:user ends with "Undefined constant Doctrine\DBAL\Types\Types::ARRAY" error HOT 6
- `make:entity` and enums HOT 2
- object is listed but no longer valid for dbal4
- [BUG] [Make:registration-form] Form errors are not handled HOT 1
- Replace `$request->request` by `$request->getPayload()` HOT 1
- Error when you use ux-turbo without mercure HOT 1
- TypeHinting setters with nullable values
- Exposing internal classes HOT 2
- [make:entity] Cannot create an entity called "Locale" HOT 2
- Make:entity requires Mercure too soon HOT 1
- [make:entity] addGetter on boolean field that starts with "is" HOT 1
- [make:entity] `generate()` call to `is_string()` appears to always evaluate to `false`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maker-bundle.