[RFC] Add a make:action command about maker-bundle HOT 6 CLOSED

+1

from maker-bundle.

I'm actually 👎 on this one. It's exactly the same as the current make:controller command except that the method name would be __invoke(). I don't think it deserves another command. Generators creates files with code you own, which should be modified anyway.

from maker-bundle.

If an overriding template mechanism is approved for this bundle (#33) then this kind of need may be easier to achieve (e.g. https://github.com/symfony/maker-bundle/pull/50/files#diff-7d25cf7d5e19ace152dd9df61498d519).

Many companies would adapt the bundle templates to their own conventions, but still the promise of BC is a pending topic in this sense.

from maker-bundle.

Ok I don't go further with a PR for now and let you decide if you want close this issue or not.

from maker-bundle.

I don't see a reason not to do it unless we want to limit the number of commands in the bundle.

from maker-bundle.

I don't want to keep issues open for months, so I propose to close this one. The first reason is that in Symfony most people use controller or action indifferently, so make:action can be understood as creating an entire controller and also, adding a new method to an existing controller.

The second reason is that we're not 100% convinced yet about promoting the ADR philosophy (see this pending PR in the Symfony Docs for example: symfony/symfony-docs#8153). We are not saying that ADR is wrong. We just don't want (yet) to promote a whole new way of doing things.

from maker-bundle.