Simplify dependency configuration for makers about maker-bundle HOT 3 CLOSED

Hey @sadikoff!

What’s the advantage of your proposal? The current implementation allows us to add other methods in the future for different situations. And I like the auto completion :)

from maker-bundle.

@weaverryan just an idea. For example I have 6 dependencies in make:crud and I need 6 times to write $dependencies->addClassDependency(...) may be we can find better way to simplify it. My initial idea was to write something like:

public function configureDependencies(DependencyBuilder $dependencies)
{
    $dependencies->addClassDependencies([
        [Route::class, 'annotations'],
        [Route::class, 'annotations'],
        [Route::class, 'annotations'],
        [Route::class, 'annotations'],
    ]);
}

Or may be we can make add(...) like in FormBuilder

public function configureDependencies(DependencyBuilder $dependencies)
{
    $dependencies
        ->addClass(Route::class, 'annotations')
        ->addClass(Route::class, 'annotations')
        ->addClass(Route::class, 'annotations')
        ->addClass(Route::class, 'annotations')
        ->addClass(Route::class, 'annotations')
    ;
}

The main advantage is that we will write less code :)

from maker-bundle.

@sadikoff I tend to agree with Ryan here. Even if your proposal is more concise, it could limit us in the future (this is an hypothesis, I don't have specific examples of what else we could do here). Also, the existing config is annoying mostly for the CRUD generator, whose complexity is an edge case. All the other makes are (a lot) simpler. Let's close for now as "won't fix". Thanks!

from maker-bundle.