Comments (5)
Thinking about this issue a bit more, I'm wondering if copying files from a package is really a feature we want to keep.
from flex.
Closing as staled. Please provide a PR ideally if you can.
from flex.
@nicolas-grekas
I would like to reopen this issue to discuss options.
The problem is described in more detail here: #604
Although it seems to me that the root cause is that \Symfony\Flex\Configurator\CopyFromPackageConfigurator::removeFilesFromDir()
iterates over files in the package to figure out what to delete from the project. This is probably to make sure Flex doesn't delete files/folders which weren't copied from the package by the recipe in the first place. However, the package no longer exists in /vendor
when this code runs.
In short,
- on composer install the
copy-from-package
stuff is copied (eg FE assets) - on composer remove there's an error and as a result the composer package is removed, but the recipe is still in symfony.lock (bundle.php entry and
copy-from-recipe
files get removed correctly)
Unless I'm missing something, the copy-from-package
functionality is broken at the moment.
@fabpot mentioned in a comment above that this functionality is in question, but 4 years later it's still there, although not fully working, as evidenced by this issue.
IMO it should either be removed or fixed - at the very least removing a package shouldn't result in an error. Maybe instead of the error, there should be a message explaining that files copied from the package have to be removed manually.
I can provide a PR if you think it makes sense to pursue this.
from flex.
Please provide a PR if you can yes!
from flex.
@nicolas-grekas
There you go #847
from flex.
Related Issues (20)
- Renaming of docker-compose.yaml in compose.yaml : postgresql does'nt work anymore HOT 8
- Unclear problem description when Flex blocks package installation (by `extra.symfony.require` rule) HOT 1
- [Feature] Recipe endpoint for private recipe should not be in the project but in the bundle
- Missing tag for version v1.21.5 ? HOT 3
- Remove importmap entries when uninstalling a package
- ComposerScriptsConfigurator can break "composer.json" filename in patch
- Symfony Flex 1.8.5 is not compatible with Composer 2.7.0
- Symfony Flex fails when using Composer 2.7.0, running as root HOT 7
- Unable to update recipe HOT 5
- PackageJsonSynchronizer is not fail safe HOT 1
- Invalid version string "master.9999999" HOT 2
- Make packages.json synchronization optional
- recipe_template_relative processing is broken for gitlab private recipe
- Remove version tag in compose file as marked as obsolete by lastest docker compose version HOT 3
- Allow organize private recipes in subdirectories HOT 5
- Feature request: Update recipes non interactive
- Suggest adding management of the compose.yml file in addition to docker-compose.yml HOT 1
- Optimized key management to avoid duplication
- Support for local stored recipe files
- Resolving dependencies fails for symfony/psr-http-message-bridge after change of recipe
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flex.