OnRequest event should wait until onWorkerStart finish about swoole-bundle HOT 7 CLOSED

Best way is to require https://github.com/hyperf/coordinator lib into composer, otherwise i would take almost all classes... @Rastusik are u OK with that, or should (copy-paste) required parts ?!

from swoole-bundle.

@pistej thank yo ufor your contribution! could you post any information about the problem? Why do you think that hyperf/coordinator is the best way to solve it? Isn't that a bug in swoole?

from swoole-bundle.

@Rastusik I'm, not sure about bug in swoole, I found info about this in official swoole (and openswoole documentation):

Before the server Start event, the Server has finished the following:

Created the Manager process
Created the Worker-Sub processes
Listening on the TCP/UDP port that was specified, no connections are accepted until this event returns
Started the OpenSwoole Timer process
After the Start event executes, the reactor threads are ready to process server events and accept connections from clients.

also:

OnWorkerStart and onStart callbacks are executed in parallel in different processes, with no order of precedence.

Hyperf fw solves that: https://github.com/hyperf/hyperf/blob/master/src/http-server/src/Server.php#L86

Coordinator lib just has functions which I would take to implement/fix this flow.

from swoole-bundle.

@Rastusik your opinion? would like to fix it some how :) thx.

from swoole-bundle.

@pistej sorry I didn't have a lot of time lately. Feel free to start a proof of concept if you wish and we will see. I'm kind of skeptical with the yeld approach here https://github.com/hyperf/hyperf/blob/master/src/http-server/src/Server.php#L87 ... but looks like it's not a real yield, so I may be wrong :)

from swoole-bundle.

@Rastusik It's not yeld, just naming... created POC PR

from swoole-bundle.

@pistej released

from swoole-bundle.