Comments (4)
problem is that the method is called setIsPublishable which imho is
wrong. the field is called publishable
so it should be setPublishable.
/cc @dantleech ok if we rename that method to match the convention of
the form layer? on StaticContent the method is also called
setPublishable without the "is".
from menu-bundle.
Yeah, I think it should be setPublishable
- should this be part of the PWF interface?
from menu-bundle.
no, the publish interface should be as minimal as possible. some content
might use some inferred logic rather than an explicit field to implement
getPublisheable
from menu-bundle.
created #72 for this.
from menu-bundle.
Related Issues (20)
- bug in QuietFactory HOT 3
- [Release Request] New release to add knp menu ^2.0 HOT 2
- Confused about changes to AbstractMenuNodeAdmin HOT 2
- KnpMenuBundle menu renderer throws an exception if it is used together with MenuBundle HOT 5
- MenuBundle disable all the knp menu extensions HOT 12
- Update docs to be explicitly clear that CmfMenuBundle must come after KnpMenuBundle in AppKernel HOT 5
- Menu Bundle depends on CoreBundle HOT 4
- [DX] Allow exceptions to be thrown during `PhpcrProvider::has` HOT 4
- Incorrect exception when requested menu does not exist. HOT 2
- [2.0] [Admin] edit doesn't work with content objects HOT 1
- Could not load type "burgov_key_value" HOT 5
- move form types out of sonata admins HOT 1
- symfony 3 support HOT 2
- New File Structure HOT 2
- Upgrade Files HOT 1
- Only register validation metadata when PHPCR is enabled
- symfony 3.0 support HOT 1
- Configure PHPCR ODM child restrictions
- Question HOT 3
- deprecated use of "request" attribute of the "knp_menu.voter" tag HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from menu-bundle.