Code Monkey home page Code Monkey logo

Comments (10)

dbu avatar dbu commented on July 28, 2024

what distros still use php < 5.3.9? debian squeeze did, but wheezy has been out for half a year now.

the problem is that we need to duplicate the HierarchyInterface to avoid hard dependency on phpcr-odm just for one interface. none of those 2 can extend the other one. could we have a meta-interface we use with the phpcr-odm models that extends both interfaces - would that work around the bug?

from media-bundle.

stof avatar stof commented on July 28, 2024

@dbu no, if both interfaces are requiring the method, making another interface extend both will trigger the same fatal error on 5.3 (except it would do it in the child interface)

from media-bundle.

awildeep avatar awildeep commented on July 28, 2024

@lsmith77 if your statement of "PHP 5.3 is EOL anyway, right?" (from twitter) is where you want to be, why not set a minimum of 5.4.x? And provide limited support for 5.3.x for people who manually change the setting back to 5.3.9+?

I find projects too hesitant to move on get stuck in the past. CMF is fairly new tech, supporting unsupported code will become an issue at some point.

from media-bundle.

lsmith77 avatar lsmith77 commented on July 28, 2024

Well as soon as we increase the requirement in the composer.json we make it imho needlessly hard. But we indeed have other problems with PHP 5.3 with this Bundle, as the stream API is also flaky causing segfaults in the test suite:
https://travis-ci.org/symfony-cmf/MediaBundle

from media-bundle.

awildeep avatar awildeep commented on July 28, 2024

Do you have any official policy for what revisions of PHP you are going to try and use? Maybe make a policy about this and remove "support" for older versions by setting a suggested minimum PHP version somewhere?

from media-bundle.

lsmith77 avatar lsmith77 commented on July 28, 2024

so far we have tried to simply support all the versions of PHP that Symfony2 itself supports. However we failed to include 5.3.3 in our travis setup, which explains how this didn't get caught.

from media-bundle.

dbu avatar dbu commented on July 28, 2024

according to http://distrowatch.com/table.php?distribution=redhat the current redhat is still at 5.3.3
the annoying thing if we up the requirement in just this bundle is that this would make symfony-cmf/symfony-cmf also not install on < 5.3.9

all in all i think the best is to add a "suggest" for now, saying that if you want to use this with phpcr-odm you most likely want 5.4 but at least 5.3.9.

from media-bundle.

Crell avatar Crell commented on July 28, 2024

For reference, Drupal is targeting 5.3.10 to avoid bugs in earlier versions.

from media-bundle.

rmsint avatar rmsint commented on July 28, 2024

+1 for adding a suggested minimum php version.

from media-bundle.

dbu avatar dbu commented on July 28, 2024

thanks lukas!

from media-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.