Prepend image configuration for other bundles (Create, Block, ..) about media-bundle HOT 10 CLOSED

not sure if we shouldn't just keep such logic inside CoreBundle.

from media-bundle.

Wondered the same, I also agree with dbu when we discussed it in symfony-cmf/create-bundle#60 (comment) :

"depends how many places use such information. if its just here and MediaBundle, i think the mediabundle should do the prepend configuration calls. if the image class and media basepath are used all over the place, we could indeed make it a configration of CoreBundle. but MediaBundle sounds like it makes a lot of sense. and nobody will be able to do any media stuff without MediaBundle.

the mediabundle could prepend image enabled and the classes and paths as needed to bundles it knows that may use media."

from media-bundle.

the MediaBundle does not depend on CoreBundle, so this prepending could get lost when somebody only uses media and CreateBundle which also does not need the CoreBundle.

as its exactly the MediaBundle providing features to other bundles, i think it is ok to do it here.

but i have to admit it will make understanding what is going on in a project using all cmf bundles yet a bit more difficult. maybe adding a comment in the CoreBundle prepend configuration could help here?

from media-bundle.

@rmsint isn't this done #48 ?

from media-bundle.

#48 is only about CreateBundle. there is also BlockBundle using images.
i see here why you wanted to have it all in CoreBundle - i think we
should not set phpcr enabled: true from MediaBundle, only set the proper
model class and such things. enabling phpcr should only happen from
CoreBundle imo.

from media-bundle.

agreed.

from media-bundle.

the block bundle has no image configuration, just the ImagineBlock that has a hard dep on MediaBundle but is only loaded if that bundle is available.

i chose to keep the classes config prepend, as it could be a configured non-standard class. its a bit tricky as i guess things now depend on whether you load CoreBundle or MediaBundle first, but in the worst case you need to configure the specific class in CreateBundle again, which you would need without the prepend anyways.

from media-bundle.

why do you think the load order would matter? CoreBundle and MediaBundle each configure different things .. so there would not be any collisions.

from media-bundle.

ah .. they both configure a basepath that indeed would overlap. not sure if this is a good idea. i think we should then maybe add some logic to the CoreBundle to not set the basepath as well if the MediaBundle is loaded. wdyt?

from media-bundle.

oh, that indeed does make sense. plus it makes it clear to somebody
reading that code that MediaBundle is also doing some prepending. we
could do the same about phpcr enabled here, to set it to enabled if no
CoreBundle is loaded that will or will not do it...

from media-bundle.