Generic approach to obtain id from path about media-bundle HOT 6 CLOSED

Do we want to keep this as it currently is for a 1.0 release?

from media-bundle.

for gaufrette i would move the whole method to the phpcr specific class.

for imagine i guess we can leave as is and refactor when we implement orm. or we could make that class phpcr specific too.

from media-bundle.

Related to this is the use of getPath, we removed it from the interfaces. So the code relying on it should also be removed:

• AbstractCmfMediaDoctrine::getFilePath
• ImagineCacheInvalidatorSubscriber::getFilePath
• MediaHelper::downloadUrl

from media-bundle.

• AbstractCmfMediaDoctrine::getFilePath

we should keep an abstract method and push the impl to phpcr only

• ImagineCacheInvalidatorSubscriber::getFilePath

should that be called PhpcrImagineCacheInvalidatorSubscriber ?

• MediaHelper::downloadUrl

i guess PhpcrMediaHelper again.

or do we need a MediaHelperInterface that we can inject into all the
above classes that can give filesystem and download paths and we inject
that into the services instead of making them abstract? depends if they
have other storage specific tasks.

from media-bundle.

I think we have to check the best implementation when integrating SonataMedia so that it stays in sync and also think an ORM implementation through.

from media-bundle.

Closed by #25

from media-bundle.