rename setParent() to setParentDocument()? about media-bundle HOT 7 CLOSED

i guess i missed this here symfony-cmf/symfony-cmf#188 because we have no sonata admin and i was looking for the sonata admin parent hack we had before the ChildExtension.

+1 to implement ChildInterface and deprecate setParent in favor of setParentDocument.

from media-bundle.

I remember some discussion about this, the phpcr file also uses parent instead of parentDocument. https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Document/AbstractFile.php#L97

Maybe that one also needs to be updated?

from media-bundle.

i think for phpcr-odm we do not want to depend on the CmfCoreBundle so i think we don't need to change there.

from media-bundle.

this is related to the discussion about the interface package. implementing the ChildInterface would create a dependency on the CoreBundle for our phpcr-odm models. we can consider that an optional dependency as not everybody will want to use the phpcr-odm models.

from media-bundle.

thought some more about this and did doctrine/phpcr-odm#484 - the annotation is called ParentDocument and it just makes more sense.

from media-bundle.

merged

from media-bundle.

if we support phpcr-odm HierarchyInterface in the admin extension, we can do all this a lot easier. see symfony-cmf/core-bundle#137

from media-bundle.