Add getSection at ResourceControllerEvent about syliusresourcebundle HOT 6 OPEN

@stefandoorn @lchrusciel I find it quite annoying that a lot of resource layer services require the request configuration, even though they often only need 1-3 parameters to do their job.
It makes it hard to reuse these services outside of the standard workflow which starts in a resource controller.
But in this case it kind of make sense.

from syliusresourcebundle.

I still think the initial idea is good, but for people having the problem I fixed this like this here: https://github.com/Setono/SyliusFacebookTrackingPlugin/blob/master/src/EventListener/TagSubscriber.php#L69

from syliusresourcebundle.

Adding a section may be a good starting point, but whole RequestConfiguration makes a lot of sense as well.

from syliusresourcebundle.

I would say it's best to sends in the whole requestConfiguration - makes it more flexible and it's strongly typed anyway. If someone wants to know other things besides the section, it can also be used.

from syliusresourcebundle.

@vvasiloi I totally can understand your point. Maybe this configuration should not be a part of an event, but easily available through container?

Forced coupling of logic to ResourceController is something that we should totally work on and improve in the future.

from syliusresourcebundle.

It's kind of already available through the container: @sylius.resource_controller.request_configuration_factory + @sylius.resource_registry

from syliusresourcebundle.