Code Monkey home page Code Monkey logo

Comments (12)

umpirsky avatar umpirsky commented on May 19, 2024

Looks cool!

What is "menu on the menu"?

from sylius.

arnolanglade avatar arnolanglade commented on May 19, 2024

The big menu on the left of the page ;)

from sylius.

umpirsky avatar umpirsky commented on May 19, 2024

I would add more space below page header and around pagination.

from sylius.

norberttech avatar norberttech commented on May 19, 2024

Looks awesome! The only thing that I dont like in this mock is column header with filters filelds ; /
One column can contain data from many db fields and if it does there are few filters at very small space and grid looks awful.
Filters can be moved above the grid or on the right of it, what do you think? Also possibility to hidde filters panel will be a nice addition :)

from sylius.

umpirsky avatar umpirsky commented on May 19, 2024

Just to mention that we must think twice before accepting this since propagating it to all templates is not a small task.

from sylius.

arnolanglade avatar arnolanglade commented on May 19, 2024

@umpirsky : I know, for the moment I just want to speak about it.

I will try to do an other mock up tomorrow. We can put filters above pagination or on the right of the page. If you can add the possibility to hide them because you do not need them all the time!

from sylius.

umpirsky avatar umpirsky commented on May 19, 2024

Yes, we can. We will iterate on this for sure.

Thanks for your work @Arn0d!

from sylius.

umpirsky avatar umpirsky commented on May 19, 2024

It would be also useful to put old design screenshot above the new one, so people can compare.

from sylius.

jjanvier avatar jjanvier commented on May 19, 2024

@Arn0d 👍 for the awesome work

  • it's better for me without all this unused space
  • +1 for the buttons (create..) on the top
  • +1 for removing the text on the rows buttons
  • +1 for the select to choose the number of lines
  • +1 for confirmation popin before deleting a resource

@norzechowicz +1 for the filters on the right side or below the title

from sylius.

arnolanglade avatar arnolanglade commented on May 19, 2024

If we keep the filter above the table, I found two solutions :

  • You have to click on the arrow icon to open filters :
    crud-list-filter-sasa-1
  • You have to click on "open filter" to poepn filters, this solution take less space :
    crud-list-filter-sasa-2

from sylius.

arnolanglade avatar arnolanglade commented on May 19, 2024

Some observations :

  • Sometimes, we can find the column "ID" on the grid, I think we can remove this column. It don't give any information to the user (who is not a developer).
  • On the show/edit page, it miss sometime the button "back"
  • The resource bundle don't manage the limit (the select Display by above), do you think it is a good idea to add the functionality to this bundle ?
  • There are lot of "resource" which have less than 5 fields, perhaps you can show/edit them in a popin?

from sylius.

pjedrzejewski avatar pjedrzejewski commented on May 19, 2024

Closing as quite a lot has changed and if we want some more improvements, we should revisit this.

from sylius.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.