Probable bug in signal propagation about sycamore HOT 4 CLOSED

I believe that this should be fixed by #612 which makes removes RcSignal in favor of making all signals Copy + 'static.

from sycamore.

I've updated the code to use sycamore 0.9.0-beta.2 and the bug is still present.
The new signals do mean, that i'll be able to refactor the code base, which will probably solve the bug in my instance.
But this could be something someone else might run into in a more complex project than mine,
Although i admit that it might be a bit of an extreme case.

Here's the link to the new version https://github.com/johnvanderholt/wasm_risk/tree/8afca8598d683801882f542ed53cae5a5e1441c4

from sycamore.

I've updated the code to use sycamore 0.9.0-beta.2 and the bug is still present. The new signals do mean, that i'll be able to refactor the code base, which will probably solve the bug in my instance. But this could be something someone else might run into in a more complex project than mine, Although i admit that it might be a bit of an extreme case.

Here's the link to the new version https://github.com/johnvanderholt/wasm_risk/tree/8afca8598d683801882f542ed53cae5a5e1441c4

I've had a quick look at your code and I believe the problem might be due to updating signals from within memos/effects.

For one thing, if you are not using the result of the memo, it is semantically more correct to use create_effect which is specifically meant for this kind of thing.

Secondly, it is generally considered much better to use memos instead of manually updating signals withy effects. This not only solves some synchronisation issues and the "diamond problem", it also generally should have much better performance.

Hope this helps!

from sycamore.

ok, good to know.
thanks, for the help.

from sycamore.