Code Monkey home page Code Monkey logo

Comments (30)

myxingkong avatar myxingkong commented on September 20, 2024 8

After some debugging, I found the problem. Swoole sets the PostgreSQL connection to non-blocking mode and does not use functions like select to listen for the connection status in non-coroutine mode. This causes the PQconnectPoll function to return immediately.

It is not possible to reproduce this problem between containers because the latency between them is small. When the PQconnectPoll function returns, the socket has been sent. This problem only occurs when trying to connect to an external server with a delay of >2ms.

Try to rebuild Swoole using the following patches, and the problem is temporarily resolved.

diff --git a/ext-src/swoole_pgsql.cc b/ext-src/swoole_pgsql.cc
index 7c8ee1649..fade6827f 100644
--- a/ext-src/swoole_pgsql.cc
+++ b/ext-src/swoole_pgsql.cc
@@ -86,7 +86,28 @@ PGconn *swoole_pgsql_connectdb(const char *conninfo) {

     PQsetnonblocking(conn, 1);

+    fd_set readfds, writefds;
+    timeval timeout = {0, 10000};
+    int retval = 0;
+    if (swoole_pgsql_blocking) {
+        FD_ZERO(&readfds);
+        FD_ZERO(&writefds);
+        FD_SET(fd, &readfds);
+        FD_SET(fd, &writefds);
+    }
+
     SW_LOOP {
+        if (swoole_pgsql_blocking) {
+            retval = select(fd + 1, &readfds, &writefds, nullptr, &timeout);
+            if (retval == -1) {
+                if (errno == EINTR) {
+                    continue;
+                }
+                return nullptr;
+            } else if (retval == 0) {
+                continue;
+            }
+        }
         int r = PQconnectPoll(conn);
         if (r == PGRES_POLLING_OK || r == PGRES_POLLING_FAILED) {
             break;

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024 6

@EliasElimah see https://github.com/swoole/swoole-src/releases/tag/v5.1.4

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024 4

@flexchar @myxingkong Here, it should be necessary to distinguish between coroutine and non-coroutine situations. Let me make the modification.

from swoole-src.

lv2u avatar lv2u commented on September 20, 2024 3

@NathanFreeman I understand you cannot reproduce the issue, because it only happens sometimes. The bug doesn't always occur on every environment and I have absolutely no idea why.

I've spend the good part of the day trying to debug this issue, because we run into this issue on 2 of our 4 DTAP environments.

In our environments, everything is running great up until the acceptance and production environments, where the 'SSL negotiation packet' error is thrown. Each environment is rolled out using the same IaC codebase. I have confirmed they are all using the same software, tools, versions and OS's.

The same image - based on your Dockerfile - is being used on all environments during my tests. I've also tested it with a Debian based image, which gives the exact same results.

Connecting from within the image to the Postgres database using the psql client works as expected, which rules out potential firewall issues.

Disabling the SSL mode - for testing only obviously - results in a could not send startup packet error message.

All things together; it looks like the PHP process just can't seem to connect with the Postgres database, even though TCP packets are send to and from the database when these errors occur.

I'm currently out of ideas how to debug this issue and provide you with the information you need. If there is anything that I missed here or anything I can do to help you out, let me know.

from swoole-src.

vic-pic avatar vic-pic commented on September 20, 2024 2

Hi,
I have the same problem with all versions starting from version 5.1, with debian and alpine, with php 8.2 and 8.3.
I'm using official swoole docker images.
With official docker images of swoole 5.0 everything works correctly.

from swoole-src.

EliasElimah avatar EliasElimah commented on September 20, 2024 2

Hello @NathanFreeman
When will the fix be released?
We've been waiting for a while.

from swoole-src.

7oku avatar 7oku commented on September 20, 2024 1

Not sure if this is of help, otherwise just another +1 here.

We have the same with a Laravel application which we try to migrate from OpenSwoole to Swoole. Our phpinfo output looks similar to the mentions above.

Our image is built FROM alpine:3.20, packages are installed as needed via apk add php82-XXX, swoole via apk add php82-pecl-swoole. That's essentially the way to reproduce it.

On start a PostgreSQL db migration on an AWS RDS instance via php artisan migrate is necessary for our app. While OpenSwoole succeeds, Swoole fails at this stage with

   Illuminate\Database\QueryException

  SQLSTATE[08006] [7] could not send SSL negotiation packet: Resource temporarily unavailable (Connection: pgsql, SQL: select * from information_schema.tables where table_catalog = <dbname> and table_schema = public and table_name = migrations and table_type = 'BASE TABLE')

  at vendor/laravel/framework/src/Illuminate/Database/Connection.php:829
    825▕                     $this->getName(), $query, $this->prepareBindings($bindings), $e
    826▕                 );
    827▕             }
    828▕
  ➜ 829▕             throw new QueryException(
    830▕                 $this->getName(), $query, $this->prepareBindings($bindings), $e
    831▕             );
    832▕         }
    833▕     }

      +35 vendor frames

  36  artisan:35
      Illuminate\Foundation\Console\Kernel::handle()

We hunt this problem for 3 months now and cannot find anything, so we're stuck with OpenSwoole currently.

Maybe you have an idea how we can debug this further from here in our app and provide you with infos?

from swoole-src.

therobfonz avatar therobfonz commented on September 20, 2024 1

For anyone running into this problem with a Laravel Forge provisioned server, here are the steps I took to disable Swoole. Forge, by default, installs the Swoole extension so users can easily run Laravel Octane, but its there whether or not you decide to use it.

vi /etc/php/8.3/cli/conf.d/25-swoole.ini

Then comment out the extension line like this

;extension=swoole.so

Restart PHP

sudo service php8.3-fpm restart

Obviously if not using 8.3, update the command to the particular version, but this fixed the could not send SSL negotiation packet error.

from swoole-src.

andypost avatar andypost commented on September 20, 2024 1

Send to build alpinelinux/aports@ee4d00d alpinelinux/aports@d89ba00

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024

It seems that I need to synchronize the code for php8.3 pdo_pgsql.

from swoole-src.

flexchar avatar flexchar commented on September 20, 2024

Swoole unfortunately doesn't work with PHP 8.3 on Alpine because the most recent published version is the one with the bug 5.1.1. Alpine maintains only the most recent version and it's related to the PECL problem. Ref #5242

from swoole-src.

myxingkong avatar myxingkong commented on September 20, 2024

I encountered the same problem on Debian, and the issue persists after attempting to upgrade PHP to 8.3.

$ uname -a
Linux 2a9a37e4e7c4 6.7.11-orbstack-00143-ge6b82e26cd22 #1 SMP Sat Mar 30 12:20:36 UTC 2024 aarch64 GNU/Linux

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 12 (bookworm)
Release:	12
Codename:	bookworm

$ php -v
PHP 8.3.6 (cli) (built: Apr 24 2024 19:23:57) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.6, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.6, Copyright (c), by Zend Technologies

$ php --ri swoole
Swoole => enabled
Author => Swoole Team <[email protected]>
Version => 5.1.2
Built => May 14 2024 03:45:52
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
cpu_affinity => enabled
spinlock => enabled
rwlock => enabled
sockets => enabled
openssl => OpenSSL 3.0.11 19 Sep 2023
dtls => enabled
http2 => enabled
json => enabled
curl-native => enabled
pcre => enabled
c-ares => 1.18.1
zlib => 1.2.13
mutex_timedlock => enabled
pthread_barrier => enabled
futex => enabled
async_redis => enabled
coroutine_pgsql => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_fiber_mock => Off => Off
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => On => On
swoole.unixsock_buffer_size => 8388608 => 8388608

from swoole-src.

flexchar avatar flexchar commented on September 20, 2024

Same here on alpine with the new version. The thing that sucks is that alpine only has the latest versions which now makes everyone stuck with the broken one. I tried switching to FrankenPHP but Swoole outperforms it by 30x in my humble benchmarks. So it's also hard to say no.

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024

@myxingkong Can you provide a script for reproduction?

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024

@flexchar Do you have coroutines enabled?

from swoole-src.

flexchar avatar flexchar commented on September 20, 2024

@NathanFreeman If this is the fair way to judge, then it seems so.

(Note this is the output from the working version)

laravel@:/var/www $ php --ri swoole

swoole

Swoole => enabled
Author => Swoole Team <[email protected]>
Version => 5.0.3
Built => May 11 2023 21:36:59
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
spinlock => enabled
rwlock => enabled
sockets => enabled
openssl => OpenSSL 3.1.0 14 Mar 2023
dtls => enabled
http2 => enabled
json => enabled
curl-native => enabled
c-ares => 1.19.1
zlib => 1.2.13
brotli => E16777225/D16777225
mutex_timedlock => enabled
pthread_barrier => enabled
mysqlnd => enabled
async_redis => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => On => On
swoole.unixsock_buffer_size => 8388608 => 8388608

I tried setting them off using the following but the issue remains the same.

[swoole]
swoole.enable_coroutine = 0

from swoole-src.

myxingkong avatar myxingkong commented on September 20, 2024

If coroutines are not used, connecting to external servers will not work properly. However, there is no problem connecting to the internal Docker server.

$dsn = 'pgsql:dbname=postgres host=192.168.199.201 port=5432';
try {
    $db = new PDO($dsn, 'postgres', '123456');
    echo "Connected successfully";
} catch (PDOException $e) {
    echo "Connection failed: " . $e->getMessage();
}

Output:

Connection failed: SQLSTATE[08006] [7] could not send SSL negotiation packet: Resource temporarily unavailable

Moving the above code into a coroutine, it can work normally.

use function Swoole\Coroutine\run;

run(function () {
    $dsn = 'pgsql:dbname=postgres host=192.168.199.201 port=5432';
    try {
        $db = new PDO($dsn, 'postgres', '123456');
        echo "Connected successfully";
    } catch (PDOException $e) {
        echo "Connection failed: " . $e->getMessage();
    }
});

Output:

Connected successfully

After attempting to disable coroutines, the problem still exists. Only when I completely disable the Swoole extension, can the problem be solved.

from swoole-src.

never615 avatar never615 commented on September 20, 2024
php -v

same problem on Debian
截屏2024-05-22 21 38 29
截屏2024-05-22 21 39 21

swoole 5.1.1 php8.2;
swoole 5.1.2 php8.2;
swoole 5.1.2 php8.3; I have tested these versions and have the same problems on debian. Test based on phpswoole/swoole docker image.

on Ubuntu,It is ok. (swoole 5.1.1 php8.3.6)

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024

I have tried many methods,

  1. php, swoole, and postgresql are directly installed on the server.
  2. php, swoole installed in a docker, postgresql on the server.
  3. php, swoole in docker A, postgresql in docker B.

None of which can be reproduced.
Is there any other information that can be provided?
@never615 @vic-pic @myxingkong @flexchar

from swoole-src.

NathanFreeman avatar NathanFreeman commented on September 20, 2024

Or execute php -m to check if php has installed pdo_pgsql.

from swoole-src.

flexchar avatar flexchar commented on September 20, 2024

@NathanFreeman,
it works if both are on the same level such as on the server or inside docker containers in the same stack. However not if swoole inside docker and pgsql on the host - your variant number 2.

Did you try the 2nd using the docker image I provided? I used Postrgres.App on mac as the database on the host and in this scenario it will cause the error.

from swoole-src.

vic-pic avatar vic-pic commented on September 20, 2024

@NathanFreeman ,
my case is that I'm running pgsql on the host machine, and it doesn't work. The same Dockerfile used to build container with swoole 5.1 that doesn't work, with swoole 5.0 works without problems.

from swoole-src.

allsilaevex avatar allsilaevex commented on September 20, 2024

@NathanFreeman

If I run Swoole v5.1.2 and PostgreSQL v15.2 on the same network via docker compose, then everything works fine. But if I assign swoole the network "net1", and postgresql the network "net2", then I get an error "could not send SSL negotiation packet".

from swoole-src.

flexchar avatar flexchar commented on September 20, 2024

Wow, you're the hero @myxingkong!

I rooting this is enough for @NathanFreeman to pin a new version and unblocks as all to upgrade to PHP 8.3 :))

from swoole-src.

korridor avatar korridor commented on September 20, 2024

I think we have the same issue since we rebuild our image for production yesterday. Is there a way to prevent this issue from happening until a fix is released?

Does this only happen if I connect to the database with SSL? Can I set the ssl mode to disabled to circumvent the issue? Or is it possible to downgrade to a Swoole version where this issue does not happen and if so do you know which version?

from swoole-src.

andreinocenti avatar andreinocenti commented on September 20, 2024

Guys, just tested an official PHP 8.3 alpine image with Swoole 5.1.(0-3) and all the time I have the same error "SQLSTATE[08006] [7] could not send SSL negotiation packet: Resource temporarily unavailable"

It is worth to note that my Postgresql DB is not on Docker, but in a separate host.

My env: php8.3 + laravel 11 + postgresql + swoole 5.1.X

Anyone has any ideia what to do?

from swoole-src.

7oku avatar 7oku commented on September 20, 2024

@andreinocenti The latest release https://github.com/swoole/swoole-src/releases/tag/v5.1.3 is from June 6th, but #5397 has been merged July 5th into main. There simply has not been any release with the fix yet, which I would expect to be either >=v5.1.4 or v6.0.

You could build from main if you need it quicker. We are still on openswoole and wait with a migration until a new swoole version with fix is released.

from swoole-src.

andreinocenti avatar andreinocenti commented on September 20, 2024

@7oku Thank you. I just found a "solution". I lowered my php version to 8.2.19 and the swoole to 5.0.3. Now it is working using these old versions.

from swoole-src.

stupid-programmer avatar stupid-programmer commented on September 20, 2024

For anyone running into this problem with a Laravel Forge provisioned server, here are the steps I took to disable Swoole. Forge, by default, installs the Swoole extension so users can easily run Laravel Octane, but its there whether or not you decide to use it.

vi /etc/php/8.3/cli/conf.d/25-swoole.ini

Then comment out the extension line like this

;extension=swoole.so

Restart PHP

sudo service php8.3-fpm restart

Obviously if not using 8.3, update the command to the particular version, but this fixed the could not send SSL negotiation packet error.

Thank you @therobfonz this worked for me, with the small change of the file being a symlink so the actual file I needed to edit was /etc/php/8.3/mods-available/swoole.ini

from swoole-src.

flexchar avatar flexchar commented on September 20, 2024

For alpine users.

Waiting for Andy Postnikov @andypost to release on Alpine: https://pkgs.alpinelinux.org/packages?name=php83-*swoole*&branch=v3.20

If anyone knows how to let him know of the new version, it'd be greatly appreciated!

from swoole-src.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.