Ruby Script Code Review about swinject-codegen HOT 8 CLOSED

I would like to do #4 and #5 before.

from swinject-codegen.

correct. snake_case is the preferred way. we should move the .rb files and .erb templates to one (or more) subfolders. currently everything lives in root.

from swinject-codegen.

I can look into this, once you pushed the initial commit.

from swinject-codegen.

@Lutzifer plz let me know when the code is ready for review.

from swinject-codegen.

I created PR #24 as code review.

One thing I didn't change in the PR was naming convention. I think snake_case is preferred to camelCase for parameter and function names in Ruby. What is your idea about this naming convention?

from swinject-codegen.

@ddengler you are the expert on that

from swinject-codegen.

I agree. Especially utility scripts should be sorted into a subdirectory. E.g. README.erb and updateReadme.sh.

from swinject-codegen.

I need to keep all the .rb files in the same folder, as I haven't found out yet whether i can include subfolders in pods. Thus, the pod has a flat hierarchy atm, which we need to mirror to use it in the examples.

Moving stuff into subfolders is great nonetheless.

from swinject-codegen.