Version published to NPM doesn't have the correct ngx-charts dependency ! about ngx-graph HOT 16 CLOSED

Sorry if I'm a bit pushy, but that issue is already solved in the repo, all there needs to be done is push a new version to NPM. And it's breaking the download of the current version.

from ngx-graph.

@marjan-georgiev

I'm having this same issue. since ngx-charts-dag declares ^6.1.0 of ngx-charts as a full dependency it uses that version and currently has breaking problems because it does not use ngx-charts ^7.0.1

Do note: ^6.1.0 only means within the 6.0.0 family and not greater than 6. Same goes for the ^4.4.6 dev dependencies. those hsould also be updated to 5.0.0 for dev

from ngx-graph.

I'm in the same boat - and a push to NPM would solve #20 for me, which would allow me to use this lib on a new project :)

from ngx-graph.

Published 3.0.1. Please let me know if this fixes the issue.

from ngx-graph.

@marjan-georgiev just putting the component on the screen i'm getting

webpack-internal:///../../../core/esm5/core.js:1546 ERROR Error: Uncaught (in promise): Error: StaticInjectorError[InjectionService]:
StaticInjectorError[InjectionService]:
NullInjectorError: No provider for InjectionService!

gonna go back through and make sure i'm not missing a dependency or something.

from ngx-graph.

The InjectionService is being provided by ngx-charts. Can you check that it appears in node_modules/@swimlane/ngx-charts?

from ngx-graph.

@isaacplmann it is showing up (.d.ts and .js files) but for some reason i'm still gettin gthat error
gonna delete my node_modules and try a reinstall

from ngx-graph.

@isaacplmann I'm still getting the error even though the files are there. any suggestions?

from ngx-graph.

Try creating a reproduction on stackblitz.com - that will help us debug it.

from ngx-graph.

@isaacplmann I'm not getting errors when I do it on stack blitz even incorporating the other libraries i'm using. Further looking into this to see what the problem is

from ngx-graph.

@isaacplmann @marjan-georgiev my problem had to do with MouseWheelDirective not having the up/down emitters defined which was fixed in 4.0.0 but is not released yet.

I have another issue incorporating with another library but i want to see if this fixes that first before I add that stuff here.

from ngx-graph.

@isaacplmann @marjan-georgiev would it be possible to release 4.0.0 to npm today?

from ngx-graph.

@kenisteward it is already released, but the package was renamed to @swimlane/ngx-graph.

Please take a look at the breaking changes in this PR's description and what you need to do to upgrade: #38

from ngx-graph.

@marjan-georgiev thanks will give it a try!

from ngx-graph.

@marjan-georgiev I suggest marking the previous library as deprecated and adding it in the readme so people don't use the incorrect one.

Also i'm currently still getting the same error

from ngx-graph.

@kenisteward Please open a separate issue for the MouseWheelDirective error.

from ngx-graph.