Code Monkey home page Code Monkey logo

Comments (2)

drenkmann avatar drenkmann commented on August 16, 2024

I would like to work on this, once my current PR has been merged/closed. Just adding the endpoint string into the url wouldn't work because the daily forecast returns an array (I think).

Instead, I would suggest adding entirely new functions for the different endpoints, using a naming scheme like QueryAsync{EndpointType}, where EndpointType would for example be Daily, resulting in the name QueryAsyncDaily.
This would also retain support for legacy codebases by leaving QueryAsync and Query alone.

Optionally, QueryAsyncCurrent could be added to improve code readability for anyone using the library. This would either use the same code as QueryAsync, or directly call QueryAsync. To encourage using the new naming scheme, QueryAsync could be marked as deprecated.

from openweathermap-api-csharp.

drenkmann avatar drenkmann commented on August 16, 2024

So after working on this all day, I have realized that the daily endpoint requires a paid subscription (which I don't have), so I'm afraid that someone who does own a paid API key will have to work on this. Alternatively, it would be possible to integrate the new Open Weather Map API V3, but that would require almost the entire library to be rewritten.

from openweathermap-api-csharp.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.