Code Monkey home page Code Monkey logo

Comments (3)

JBorrow avatar JBorrow commented on June 7, 2024

Thanks! You're totally correct here. I've looked at some of our private checkouts of the script that we've used for various works, and they have this issue corrected; it must just be something that we've forgotten to push upstream at some point. I will address this in the GitLab version of the repo (our GitHub repo is just a copy of the GitLab one) and close this when appropriate.

Thanks again for reporting this. It's very helpful! Glad you're making use of the script; I would suggest that for now you go ahead and use your fixed version that correctly creates the BCC lattice.

from swift.

JBorrow avatar JBorrow commented on June 7, 2024

The GitLab merge request is here: https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1733

from swift.

JBorrow avatar JBorrow commented on June 7, 2024

Thank you! We've now fixed this in the main codebase. The changes will synchronise with the master branch on GitHub tonight.

https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1733/diffs#note_49912

Thanks again for reporting this!

from swift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.