Comments (4)
emersion
commented on July 28, 2024
Hm I think this happens because there's no damage. Can you try this to confirm?
diff --git a/backend/drm/atomic.c b/backend/drm/atomic.c
index 70f55afff614..18060ea7d681 100644
--- a/backend/drm/atomic.c
+++ b/backend/drm/atomic.c
@@ -205,6 +205,7 @@ static bool atomic_crtc_commit(struct wlr_drm_connector *conn,
int rects_len;
const pixman_box32_t *rects = pixman_region32_rectangles(
(pixman_region32_t *)&state->base->damage, &rects_len);
+ wlr_log(WLR_INFO, "FB_DAMAGE_CLIPS: len=%d", rects_len);
if (drmModeCreatePropertyBlob(drm->fd, rects,
sizeof(*rects) * rects_len, &fb_damage_clips) != 0) {
wlr_log_errno(WLR_ERROR, "Failed to create FB_DAMAGE_CLIPS property blob");from wlroots.
fbernier
commented on July 28, 2024
That seems to be the case indeed:
00:02:12.624 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.624 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.624 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.633 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.633 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.633 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.633 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.639 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=1
00:02:12.639 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=1
00:02:12.641 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.641 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.641 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.641 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.649 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.649 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.649 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=0
00:02:12.649 [ERROR] [wlr] [backend/drm/atomic.c:211] Failed to create FB_DAMAGE_CLIPS property blob: Invalid argument
00:02:12.657 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=1
00:02:12.657 [INFO] [wlr] [backend/drm/atomic.c:208] FB_DAMAGE_CLIPS: len=1
Although I noticed that if I tail the log file in my terminal and move the cursor around, the len is always > 0 but as soon as I move to another monitor than where my terminal is, the errors start popping up when I move the cursor.
from wlroots.
emersion
commented on July 28, 2024
Does this help? #3314
from wlroots.
fbernier
commented on July 28, 2024
It does fix the issue. Thanks!
from wlroots.
Related Issues (20)
- EGL fails to initialize on etnaviv with EGL_PLATFORM_DEVICE_EXT HOT 3
- scene: add a way to crop and scale surface nodes
- scene: consider removing surface nodes
- scene: add presentation-time support
- Firefox Nightly with with Wayland compositing force enable will crash on launch (Vulkan) HOT 3
- vulkan: Remove hard dependency on validation layer
- SEGV on wlr_output_destroy HOT 6
- Pixman renderer asserts when using scene graph HOT 8
- Rootless compositor example HOT 1
- render/vulkan: support screencopy
- wlr_scene doesn’t use pending output size HOT 1
- Pixman renderer rejects externally-created buffers HOT 1
- Two DataOffer events when taking the clipboard
- Scene graph allocates zero-sized buffers HOT 1
- Undefined symbol:drmIsKMSname="(unset)" requested_reply="0" HOT 5
- scene: add a function to get a node from a surface
- render/vulkan: add support for YUV formats
- scene surface-tree uses previous position for subsurfaces
- wlroots 0.15.0 issue HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wlroots.