Comments (7)
You're right, both the ServicesResetterProcessorConfigurator
of this bundle and the ServicesResetterProcessor
in swarrot/swarrot are not compatible with sf3.4.
You can still migrate to SwarrotBundle 1.8 if you don't use this processor.
If you want out of the box support of this reset behavior with sf 3.4, you can propose a PR to update the existing processor & processor configurator in both the lib & the bundle.
Tell me it it's clear for you?
from swarrotbundle.
@odolbeau it is clear thank you,
but shouldn't then the composer of both lib and bundle be updated in the require part to be sf4+ ?
I will for now stay on version 1.7 on this project, will upgrade when upgrading to sf4.4
thank you again
from swarrotbundle.
Do you have this problem as soon as you update the SwarrotBundle?
It's strange cause as all processors are optional, you should not have this processors configurator called if you don't add services_resetter
in your processors_stack
.
from swarrotbundle.
Oh OK, your test is failing cause your trying the retrieve the service even if you don't use it... :/
from swarrotbundle.
Yep indeed, as the lint:container command is on 4.4, we do have a "bare test" that loop the container services
that is why I found this
Maybe removing the require ^3.4 from composer is a good start IMO, or add dependencies to sf/contracts ?
from swarrotbundle.
The only thing which breaks is your test. :)
Swarrot should works just fine with sf3.4 as soon as you don't use this processor.
Removing the sf3.4 support for an optional processor which is not compatible is not a good idea IMO.
The container:lint
command only compile the container, it does not try to access to all declared services. Maybe you could update your test to do the same?
from swarrotbundle.
ok understood @odolbeau
We will stay on 1.7 until going symfony 4.4 as I wrote earlier
Would like to avoid having "sleeping non callable code" that can break
May I propose a PR for adding an hint here https://github.com/swarrot/swarrot/blob/master/src/Swarrot/Processor/ServicesResetter/ServicesResetterProcessor.php#L13 about requiring sf4+ or specific usage of sf/contratcs?
lets close for now I've got my answer, thank you :)
from swarrotbundle.
Related Issues (20)
- Flex recipes ? HOT 2
- Problem when type hinting method process in PHP7 HOT 5
- dot in messages-types are lost in the command help HOT 1
- Why the message type is not used as the queue name by default HOT 3
- Symfony 4.3 deprecations HOT 3
- Symfony Messenger and Swarrot compatibility HOT 1
- Reset application after each consummed message HOT 1
- Install Fail HOT 2
- Allow users to attach aliases to Swarrot commands HOT 2
- make queue declare before consume queue HOT 1
- Make Swarrot commands lazy HOT 2
- Consumer on multiple queues HOT 3
- Port cannot be configured by env var HOT 2
- Upgrade Doctrine dependencies HOT 4
- AMQPS configuration
- Multiple hosts support HOT 2
- Symfony 6 compatibility HOT 1
- CI needs to migrate away from Travis
- Non-existed services HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swarrotbundle.