Code Monkey home page Code Monkey logo

Comments (21)

dk3775 avatar dk3775 commented on August 15, 2024 1

@Ayush-Kanduri Still you do have a green light..
But the buttons and the output box is fixed by #392 .

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024 1

Hi Dhyey, I have worked on this issue & made a PR #408 .

Kindly Merge my PR, I would be glad.

from geeksay.

gerasaka avatar gerasaka commented on August 15, 2024 1

Hello, can I work for this too?

from geeksay.

gerasaka avatar gerasaka commented on August 15, 2024 1

I also have some suggestions

  1. I think the "random quote" button and the "tweet" button would be better if they had the same right-alignment

  1. "tweet" button hover looks like it could be improved

  2. it looks like the buttons have inconsistent font size

  3. fix margin for smaller viewport

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024 1

@gerasaka Go on !

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024

If you Green Light this issue, can I work on it?

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

Actually, the new copy button is creating this issue, Although you can contribute here for the same issue -> #369.

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024

@Ayush-Kanduri Still you do have a green light.. But the buttons and the output box is fixed by #392 .

Thanks, Dhyey 😀 I'll see if something is there that needs to be done.

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

Sure !

from geeksay.

Wodlfvllf avatar Wodlfvllf commented on August 15, 2024

Sir I want to work.

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

@Wodlfvllf yes you can go on!

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

#408 Fixed this issue but still I think we can work around the social buttons after the translated textbox and only copy button above the text box,
Furthermore, we can add a share to Facebook button also.

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024

#408 Fixed this issue but still I think we can work around the social buttons after the translated textbox and only copy button above the text box, Furthermore, we can add a share to Facebook button also.

Yes that's what I was thinking, like copy button to be above the translation box and social buttons to be below the translation box.
I'll see to it, what could be done.

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

We could also bring the Copy button inline with the text then, it would look better I guess.

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024

We could also bring the Copy button inline with the text then, it would look better I guess.

What about, if we put the copy button inside the translate box?

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

I think the button looks great outside the box.

from geeksay.

Mayank7225 avatar Mayank7225 commented on August 15, 2024

can i work on this?

from geeksay.

dk3775 avatar dk3775 commented on August 15, 2024

@Mayank7225 yes

from geeksay.

ferrorenan avatar ferrorenan commented on August 15, 2024

I'd like to work with it, can I!?

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024

Hi @dk3775, Added the Social Buttons + Removed some existing errors as well.

All mentioned in Pull Request #440

from geeksay.

Ayush-Kanduri avatar Ayush-Kanduri commented on August 15, 2024

Issue Completed

from geeksay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.