Comments (21)
@Ayush-Kanduri Still you do have a green light..
But the buttons and the output box is fixed by #392 .
from geeksay.
Hi Dhyey, I have worked on this issue & made a PR #408 .
Kindly Merge my PR, I would be glad.
from geeksay.
Hello, can I work for this too?
from geeksay.
I also have some suggestions
- I think the "random quote" button and the "tweet" button would be better if they had the same right-alignment
-
it looks like the buttons have inconsistent font size
-
fix margin for smaller viewport
from geeksay.
@gerasaka Go on !
from geeksay.
If you Green Light this issue, can I work on it?
from geeksay.
Actually, the new copy button is creating this issue, Although you can contribute here for the same issue -> #369.
from geeksay.
@Ayush-Kanduri Still you do have a green light.. But the buttons and the output box is fixed by #392 .
Thanks, Dhyey 😀 I'll see if something is there that needs to be done.
from geeksay.
Sure !
from geeksay.
Sir I want to work.
from geeksay.
@Wodlfvllf yes you can go on!
from geeksay.
#408 Fixed this issue but still I think we can work around the social buttons after the translated textbox and only copy button above the text box,
Furthermore, we can add a share to Facebook button also.
from geeksay.
#408 Fixed this issue but still I think we can work around the social buttons after the translated textbox and only copy button above the text box, Furthermore, we can add a share to Facebook button also.
Yes that's what I was thinking, like copy button to be above the translation box and social buttons to be below the translation box.
I'll see to it, what could be done.
from geeksay.
We could also bring the Copy button inline with the text then, it would look better I guess.
from geeksay.
We could also bring the Copy button inline with the text then, it would look better I guess.
What about, if we put the copy button inside the translate box?
from geeksay.
I think the button looks great outside the box.
from geeksay.
can i work on this?
from geeksay.
@Mayank7225 yes
from geeksay.
I'd like to work with it, can I!?
from geeksay.
Hi @dk3775, Added the Social Buttons + Removed some existing errors as well.
All mentioned in Pull Request #440
from geeksay.
Issue Completed
from geeksay.
Related Issues (20)
- Chrome extension, that will translate page to geek HOT 9
- Some experience with the project HOT 1
- Text overflows HOT 1
- Ferl HOT 1
- Two word translations not working HOT 5
- No copy to clipboard button HOT 1
- No copy to clipboard button HOT 8
- New system/form for adding new Quotes and Translations HOT 14
- Create a copy button HOT 16
- BUTTON RANDOM QUOTE AND COPY QUOTE NOT WORKING HOT 3
- Translation issue while reading numeric values HOT 5
- Update Readme.md for better styling. HOT 6
- Typo preventing buttons to function HOT 1
- I want to update the regular function with the arrow functions. HOT 3
- UI enhancement HOT 5
- 'node_modules' is not recognized as an internal or external command, HOT 1
- gallery addition HOT 2
- feat(Hactober Fest 2023) - Added a cool quote and a translation used in it
- Share button not displaying. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geeksay.